Add additive animation support for CSS property background-position

Add additive animation support for CSS property background-position

This patch adds support for composite modes on background-position
CSS animations via element.animate().

BUG=437696
Committed: https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7
Cr-Commit-Position: refs/heads/master@{#376155}

Committed: https://crrev.com/6959c1a7fcfd89f7548292c1646f9a970fdcbf0c
Cr-Commit-Position: refs/heads/master@{#377529}

[alancutter (OOO until 2018), 2016-02-10 02:59:21]

Description was changed from

==========
Add additive animation support for *-position CSS properties

This patch adds support for composite modes via element.animate() for
the following CSS properties:
 - background-position-x
 - background-position-y
 - -webkit-mask-position-x
 - -webkit-mask-position-y

BUG=437696
==========

to

==========
Add additive animation support for CSS property background-position

This patch adds support for composite modes on background-position
CSS animations via element.animate().

BUG=437696
==========

[alancutter (OOO until 2018), 2016-02-10 02:59:21]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[alancutter (OOO until 2018), 2016-02-10 03:03:51]

alancutter@chromium.org changed reviewers:
+ haraken@chromium.org

[alancutter (OOO until 2018), 2016-02-10 03:03:51]

+haraken for changes to wtf/RefVector.h.

[Eric Willigers, 2016-02-16 07:13:34]

lgtm

In a separate patch, should we rename
LayoutTests/animations/interpolation/background-position-origin-interpolation.html
to
LayoutTests/animations/interpolation/background-position-interpolation.html

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/composition/background-position-composition.html
(right):

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/composition/background-position-composition.html:61:
underlying: '40px 40px',
Can underlying, replaceFrom, addTo please differ for x and y.

[haraken, 2016-02-16 18:43:41]

wtf/ LGTM

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/RefVector.h (right):

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/RefVector.h:19: static PassRefPtr<RefVector>
create(Vector<T>&& v) { return adoptRef(new RefVector<T>(v)); }

v => vector (Blink prefers a fully qualified name.)

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/RefVector.h:39: RefVector(Vector<T>&& v) :
m_vector(v) { }

Ditto.

[alancutter (OOO until 2018), 2016-02-17 06:39:50]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2016-02-17 06:39:51]

+dstockwell for changes to core.gypi.


> In a separate patch, should we rename
>
LayoutTests/animations/interpolation/background-position-origin-interpolation.html
> to
> LayoutTests/animations/interpolation/background-position-interpolation.html

background-position-interpolation.html already exists.
background-position-origin-interpolation.html tests the positional keywords
(left, right, top, bottom).

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/composition/background-position-composition.html
(right):

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/composition/background-position-composition.html:61:
underlying: '40px 40px',
On 2016/02/16 at 07:13:34, Eric Willigers wrote:
> Can underlying, replaceFrom, addTo please differ for x and y.

Done.

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/RefVector.h (right):

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/RefVector.h:19: static PassRefPtr<RefVector>
create(Vector<T>&& v) { return adoptRef(new RefVector<T>(v)); }
On 2016/02/16 at 18:43:41, haraken wrote:
> v => vector (Blink prefers a fully qualified name.)

Done.

https://codereview.chromium.org/1680803003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/RefVector.h:39: RefVector(Vector<T>&& v) :
m_vector(v) { }
On 2016/02/16 at 18:43:41, haraken wrote:
> Ditto.

Done.

[dstockwell, 2016-02-18 02:59:44]

lgtm

[alancutter (OOO until 2018), 2016-02-18 04:42:33]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 04:42:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680803003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680803003/100001

[commit-bot: I haz the power, 2016-02-18 04:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 04:46:32]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-02-18 07:01:28]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 07:03:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680803003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680803003/120001

[commit-bot: I haz the power, 2016-02-18 08:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 08:13:22]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-02-18 13:04:02]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-18 13:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, ericwilligers@chromium.org, dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1680803003/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2016-02-18 13:04:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680803003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680803003/120001

[commit-bot: I haz the power, 2016-02-18 13:11:24]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-18 13:12:42]

Description was changed from

==========
Add additive animation support for CSS property background-position

This patch adds support for composite modes on background-position
CSS animations via element.animate().

BUG=437696
==========

to

==========
Add additive animation support for CSS property background-position

This patch adds support for composite modes on background-position
CSS animations via element.animate().

BUG=437696

Committed: https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7
Cr-Commit-Position: refs/heads/master@{#376155}
==========

[commit-bot: I haz the power, 2016-02-18 13:12:43]

Patchset 7 (id:??) landed as
https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7
Cr-Commit-Position: refs/heads/master@{#376155}

[Theresa, 2016-02-18 17:23:07]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1708303002/ by twellington@chromium.org.

The reason for reverting is: Causing compilation to fail on Android
arm64, x64, x86, and MIPS dbg builds, see
https://code.google.com/p/chromium/issues/detail?id=587875

Sheriff is reverting..

[Fady Samuel, 2016-02-18 19:25:55]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1711923002/ by fsamuel@chromium.org.

The reason for reverting is:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=an...

failing. This sounds related. Reverting..

[alancutter (OOO until 2018), 2016-02-25 03:13:49]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-25 03:13:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dstockwell@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1680803003/#ps160001
(title: "Remove redundant braces")

[commit-bot: I haz the power, 2016-02-25 03:16:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680803003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680803003/160001

[commit-bot: I haz the power, 2016-02-25 06:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 06:26:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2016-02-25 06:45:07]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-02-25 06:46:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680803003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680803003/160001

[commit-bot: I haz the power, 2016-02-25 07:57:29]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-02-25 07:59:04]

Description was changed from

==========
Add additive animation support for CSS property background-position

This patch adds support for composite modes on background-position
CSS animations via element.animate().

BUG=437696

Committed: https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7
Cr-Commit-Position: refs/heads/master@{#376155}
==========

to

==========
Add additive animation support for CSS property background-position

This patch adds support for composite modes on background-position
CSS animations via element.animate().

BUG=437696

Committed: https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7
Cr-Commit-Position: refs/heads/master@{#376155}

Committed: https://crrev.com/6959c1a7fcfd89f7548292c1646f9a970fdcbf0c
Cr-Commit-Position: refs/heads/master@{#377529}
==========

[commit-bot: I haz the power, 2016-02-25 07:59:06]

Patchset 9 (id:??) landed as
https://crrev.com/6959c1a7fcfd89f7548292c1646f9a970fdcbf0c
Cr-Commit-Position: refs/heads/master@{#377529}