third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp - Issue 1680803003: Add additive animation support for CSS property background-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp

Issue 1680803003: Add additive animation support for CSS property background-position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove redundant braces Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp

diff --git a/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp b/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp

index 52bee75065219cb2b52f235bd88681a31de20f11..1f2a93c541d2a1f86839991759317ee4af9d5121 100644

--- a/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp

+++ b/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp

@@ -16,6 +16,7 @@

#include "core/animation/CSSNumberInterpolationType.h"

#include "core/animation/CSSPaintInterpolationType.h"

#include "core/animation/CSSPathInterpolationType.h"

+#include "core/animation/CSSPositionAxisListInterpolationType.h"

#include "core/animation/CSSShadowListInterpolationType.h"

#include "core/animation/CSSValueInterpolationType.h"

#include "core/animation/CSSVisibilityInterpolationType.h"

@@ -174,6 +175,12 @@ const InterpolationTypes* PropertyInterpolationTypesMapping::get(const PropertyH

case CSSPropertyMotionRotation:

applicableTypes->append(adoptPtr(new CSSMotionRotationInterpolationType(cssProperty)));

break;

+ case CSSPropertyBackgroundPositionX:

+ case CSSPropertyBackgroundPositionY:

+ case CSSPropertyWebkitMaskPositionX:

+ case CSSPropertyWebkitMaskPositionY:

+ applicableTypes->append(adoptPtr(new CSSPositionAxisListInterpolationType(cssProperty)));

+ break;

default:

// TODO(alancutter): Support all interpolable CSS properties here so we can stop falling back to the old StyleInterpolation implementation.

if (CSSPropertyMetadata::isInterpolableProperty(cssProperty))