Add additive animation support for CSS properties perspective-origin and object-position

Add additive animation support for CSS properties perspective-origin and object-position

This patch adds support for composite modes on perspective-origin and
object-position CSS animations via element.animate().

BUG=437696
Committed: https://crrev.com/d6c733e74a01031842f94995898f4fd885dd9a54
Cr-Commit-Position: refs/heads/master@{#376156}

Committed: https://crrev.com/3d239903548b2c4c8b29185f5f5c66c1ab7e7dfe
Cr-Commit-Position: refs/heads/master@{#377728}

[alancutter (OOO until 2018), 2016-02-10 06:46:46]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2016-02-10 10:12:56]

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/composition/perspective-origin-composition.html
(right):

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/composition/perspective-origin-composition.html:54:
replaceTo: '200px 200px',
Can we have x != y for a replaceTo test.

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html
(right):

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html:136:
to: 'right bottom 50%',
Why change to 50% ?

[alancutter (OOO until 2018), 2016-02-11 01:22:27]

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/composition/perspective-origin-composition.html
(right):

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/composition/perspective-origin-composition.html:54:
replaceTo: '200px 200px',
On 2016/02/10 at 10:12:56, Eric Willigers wrote:
> Can we have x != y for a replaceTo test.

Done.

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html
(right):

https://codereview.chromium.org/1690543002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html:136:
to: 'right bottom 50%',
On 2016/02/10 at 10:12:56, Eric Willigers wrote:
> Why change to 50% ?

Transitions outputs 0px instead of 0% for bottom 100%, I'm side stepping having
to add an expectations file by using 50%.

[Eric Willigers, 2016-02-11 02:03:44]

lgtm

[alancutter (OOO until 2018), 2016-02-11 04:59:58]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2016-02-11 04:59:58]

+dstockwell for core.gypi changes.

[dstockwell, 2016-02-15 23:43:15]

lgtm

[alancutter (OOO until 2018), 2016-02-18 04:48:22]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 04:49:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690543002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690543002/60001

[commit-bot: I haz the power, 2016-02-18 04:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 04:51:31]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-02-18 07:08:30]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 07:08:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690543002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690543002/80001

[commit-bot: I haz the power, 2016-02-18 08:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 08:52:24]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-02-18 13:12:00]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-18 13:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1690543002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-02-18 13:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690543002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690543002/80001

[commit-bot: I haz the power, 2016-02-18 13:19:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-18 13:20:41]

Description was changed from

==========
Add additive animation support for CSS properties perspective-origin and
object-position

This patch adds support for composite modes on perspective-origin and
object-position CSS animations via element.animate().

BUG=437696
==========

to

==========
Add additive animation support for CSS properties perspective-origin and
object-position

This patch adds support for composite modes on perspective-origin and
object-position CSS animations via element.animate().

BUG=437696

Committed: https://crrev.com/d6c733e74a01031842f94995898f4fd885dd9a54
Cr-Commit-Position: refs/heads/master@{#376156}
==========

[commit-bot: I haz the power, 2016-02-18 13:20:42]

Patchset 5 (id:??) landed as
https://crrev.com/d6c733e74a01031842f94995898f4fd885dd9a54
Cr-Commit-Position: refs/heads/master@{#376156}

[Theresa, 2016-02-18 17:18:41]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1708293002/ by twellington@chromium.org.

The reason for reverting is: The patchset this is dependent on is causing
compilation to fail on Android
arm64, x64, x86, and MIPS dbg builds, see
https://code.google.com/p/chromium/issues/detail?id=587875

Sheriff is reverting..

[alancutter (OOO until 2018), 2016-02-25 03:20:06]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 03:20:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690543002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690543002/100001

[commit-bot: I haz the power, 2016-02-25 04:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 04:38:06]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-02-25 23:18:30]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-25 23:18:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1690543002/#ps100001
(title: "Rebased")

[commit-bot: I haz the power, 2016-02-25 23:29:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690543002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690543002/100001

[commit-bot: I haz the power, 2016-02-26 00:27:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-26 00:29:26]

Description was changed from

==========
Add additive animation support for CSS properties perspective-origin and
object-position

This patch adds support for composite modes on perspective-origin and
object-position CSS animations via element.animate().

BUG=437696

Committed: https://crrev.com/d6c733e74a01031842f94995898f4fd885dd9a54
Cr-Commit-Position: refs/heads/master@{#376156}
==========

to

==========
Add additive animation support for CSS properties perspective-origin and
object-position

This patch adds support for composite modes on perspective-origin and
object-position CSS animations via element.animate().

BUG=437696

Committed: https://crrev.com/d6c733e74a01031842f94995898f4fd885dd9a54
Cr-Commit-Position: refs/heads/master@{#376156}

Committed: https://crrev.com/3d239903548b2c4c8b29185f5f5c66c1ab7e7dfe
Cr-Commit-Position: refs/heads/master@{#377728}
==========

[commit-bot: I haz the power, 2016-02-26 00:29:27]

Patchset 6 (id:??) landed as
https://crrev.com/3d239903548b2c4c8b29185f5f5c66c1ab7e7dfe
Cr-Commit-Position: refs/heads/master@{#377728}