Fix usage of deprecated method stringByAddingPercentEscapesUsingEncoding:.

Fix usage of deprecated method stringByAddingPercentEscapesUsingEncoding:.

The method -[NSString stringByAddingPercentEscapesUsingEncoding:] has been
deprecated with 10.11 OS X SDK and 9.0 iOS SDK. The recommended method is
-[NSString stringByAddingPercentEncodingWithAllowedCharacters:] available
since 10.9 OS X SDK and 7.0 iOS SDK.

Use the new method when available using URLQueryAllowedCharacterSet to get
the same encoded string.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/450491f4f76bb42299445dbdb35be849bf8c8921

[sdefresne, 2016-02-08 11:18:09]

sdefresne@chromium.org changed reviewers:
+ mark@chromium.org

[sdefresne, 2016-02-08 11:18:10]

Please take a look.

This is a partial reland of https://codereview.chromium.org/1563223004/ using
the correct NSCharacterSet when calling
stringByAddingPercentEncodingWithAllowedCharacters:.

I've validated the encoded string is the same using the following small swift
program (only validated on the first 4096 unicode code points, but I guess it
won't fail for the rest of the valid unicode code points):

import UIKit

var str: String = ""
for i in 0...4096 {
  let c = Character(UnicodeScalar(i))
  str += String(c)
}

let t = str
let x = str.stringByAddingPercentEscapesUsingEncoding(NSUTF8StringEncoding)!
let y = str.stringByAddingPercentEncodingWithAllowedCharacters(
    NSCharacterSet.URLQueryAllowedCharacterSet())!
let equal = x == y

[Mark Mentovai, 2016-02-08 15:09:26]

LGTM

[sdefresne, 2016-02-08 16:39:29]

Description was changed from

==========
Fix usage of deprecated method stringByAddingPercentEscapesUsingEncoding:.

The method -[NSString stringByAddingPercentEscapesUsingEncoding:] has been
deprecated with 10.11 OS X SDK and 9.0 iOS SDK. The recommended method is
-[NSString stringByAddingPercentEncodingWithAllowedCharacters:] available
since 10.9 OS X SDK and 7.0 iOS SDK.

Use the new method when available using URLQueryAllowedCharacterSet to get
the same encoded string.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
==========

to

==========
Fix usage of deprecated method stringByAddingPercentEscapesUsingEncoding:.

The method -[NSString stringByAddingPercentEscapesUsingEncoding:] has been
deprecated with 10.11 OS X SDK and 9.0 iOS SDK. The recommended method is
-[NSString stringByAddingPercentEncodingWithAllowedCharacters:] available
since 10.9 OS X SDK and 7.0 iOS SDK.

Use the new method when available using URLQueryAllowedCharacterSet to get
the same encoded string.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/450491f4f76bb42299445db...
==========

[sdefresne, 2016-02-08 16:39:30]

Committed patchset #1 (id:1) manually as
450491f4f76bb42299445dbdb35be849bf8c8921 (presubmit successful).