Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1563223004: Fix deprecatation warning when building for recent SDKs on iOS/OS X. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai, Olivier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix deprecatation warning when building for recent SDKs on iOS/OS X. Fixes the following compilation warning when using recent version of the iOS or OS X SDK by using the recommended new API: ../../breakpad/src/common/mac/HTTPMultipartUpload.m:56:10: error: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid. [-Werror,-Wdeprecated-declarations] [key stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]; ^ CFURLCreateStringByAddingPercentEscapes ../../breakpad/src/common/mac/HTTPMultipartUpload.m:207:29: error: 'sendSynchronousRequest:returningResponse:error:' is deprecated: first deprecated in iOS 9.0 - Use [NSURLSession dataTaskWithRequest:completionHandler:] (see NSURLSession.h [-Werror,-Wdeprecated-declarations] data = [NSURLConnection sendSynchronousRequest:req ^ ../../breakpad/src/client/mac/handler/minidump_generator.cc:158:6: error: 'CFPropertyListCreateFromXMLData' is deprecated: first deprecated in iOS 8.0 - Use CFPropertyListCreateWithData instead. [-Werror,-Wdeprecated-declarations] (CFPropertyListCreateFromXMLData(NULL, data, kCFPropertyListImmutable, ^ BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675 BUG=569158 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/7cc0d8562bf8b20b88cc941ba72593cb7230ecf6

Patch Set 1 #

Total comments: 21

Patch Set 2 : Address first round of comments #

Patch Set 3 : Add missing "\" in #ifdef block #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -10 lines) Patch
M src/client/mac/handler/minidump_generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/common/mac/HTTPMultipartUpload.m View 1 2 4 chunks +59 lines, -7 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
sdefresne
Please take a look (let's hope no-one else already did address those compilation errors this ...
4 years, 11 months ago (2016-01-07 15:53:42 UTC) #4
Mark Mentovai
We dealt with the NSURLRequest thing in Crashpad already (https://codereview.chromium.org/1395673002) but not yet in Breakpad. ...
4 years, 11 months ago (2016-01-07 17:19:16 UTC) #5
sdefresne
Please take another look. https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipartUpload.m File src/common/mac/HTTPMultipartUpload.m (right): https://codereview.chromium.org/1563223004/diff/1/src/common/mac/HTTPMultipartUpload.m#newcode34 src/common/mac/HTTPMultipartUpload.m:34: // deprecated with iOS 9.0 ...
4 years, 11 months ago (2016-01-07 17:45:49 UTC) #6
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-07 18:22:03 UTC) #7
sdefresne
Committed patchset #3 (id:40001) manually as 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6 (presubmit successful).
4 years, 11 months ago (2016-01-07 18:48:29 UTC) #9
Olivier
https://codereview.chromium.org/1563223004/diff/40001/src/common/mac/HTTPMultipartUpload.m File src/common/mac/HTTPMultipartUpload.m (right): https://codereview.chromium.org/1563223004/diff/40001/src/common/mac/HTTPMultipartUpload.m#newcode47 src/common/mac/HTTPMultipartUpload.m:47: [NSCharacterSet alphanumericCharacterSet]]; This should be URLQueryAllowedCharacterSet Using alphanumericCharacterSet cause ...
4 years, 11 months ago (2016-01-21 09:12:31 UTC) #11
Mark Mentovai
4 years, 11 months ago (2016-01-21 15:08:41 UTC) #12
Message was sent while issue was closed.
Note the revert at https://codereview.chromium.org/1619603002/

Powered by Google App Engine
This is Rietveld 408576698