Fix usage of deprecated method sendSynchronousRequest:returningResponse:error:.

Fix usage of deprecated method sendSynchronousRequest:returningResponse:error:.

The method -[NSURLConnection sendSynchronousRequest:returningResponse:error:]
has been deprecated in 10.11 OS X SDK and 9.0 iOS SDK without replacement. So
emulate a synchronous request by using an asynchronous request and waiting on
a semaphore for the request completion.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/4becb1170940e78bfbc255aa164aca5c9523671c

[sdefresne, 2016-02-08 13:03:30]

sdefresne@chromium.org changed reviewers:
+ mark@chromium.org

[sdefresne, 2016-02-08 13:03:31]

This is a partial reland of https://codereview.chromium.org/1563223004/.

The original CL did not properly manage the objects lifetime. As data, resp and
err are released once the completionHandler complete, we need to copy them to
__block local variable, retain them and autorelease them before returning from
SendSynchronousNSURLRequest.

[Mark Mentovai, 2016-02-08 15:12:56]

LGTM

[sdefresne, 2016-02-08 16:39:46]

Description was changed from

==========
Fix usage of deprecated method sendSynchronousRequest:returningResponse:error:.

The method -[NSURLConnection sendSynchronousRequest:returningResponse:error:]
has been deprecated in 10.11 OS X SDK and 9.0 iOS SDK without replacement. So
emulate a synchronous request by using an asynchronous request and waiting on
a semaphore for the request completion.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
==========

to

==========
Fix usage of deprecated method sendSynchronousRequest:returningResponse:error:.

The method -[NSURLConnection sendSynchronousRequest:returningResponse:error:]
has been deprecated in 10.11 OS X SDK and 9.0 iOS SDK without replacement. So
emulate a synchronous request by using an asynchronous request and waiting on
a semaphore for the request completion.

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=675
BUG=569158
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/4becb1170940e78bfbc255a...
==========

[sdefresne, 2016-02-08 16:39:47]

Committed patchset #2 (id:20001) manually as
4becb1170940e78bfbc255aa164aca5c9523671c (presubmit successful).