Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: runtime/observatory/tests/service/tcp_socket_service_test.dart

Issue 1680593004: dart:developer service extension fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/tcp_socket_service_test.dart
diff --git a/runtime/observatory/tests/service/tcp_socket_service_test.dart b/runtime/observatory/tests/service/tcp_socket_service_test.dart
index c80cad5626763c4b298195935c205b3911766dd1..646b5f641deaf424f3cc4b5a1ffd3fd2d962ea89 100644
--- a/runtime/observatory/tests/service/tcp_socket_service_test.dart
+++ b/runtime/observatory/tests/service/tcp_socket_service_test.dart
@@ -30,7 +30,8 @@ Future setupTCP() async {
var tcpTests = [
// Initial.
(Isolate isolate) async {
- var result = await isolate.invokeRpcNoUpgrade('__getOpenSockets', {});
+ var result =
+ await isolate.invokeRpcNoUpgrade('ext.dart.io.getOpenSockets', {});
expect(result['type'], equals('_opensockets'));
// We expect 3 sockets to be open (in this order):
// The server socket accepting connections, on port X
@@ -48,7 +49,7 @@ var tcpTests = [
expect(result['data'][2]['name'].startsWith('127.0.0.1:'), isTrue);
var listening = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][0]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][0]['id'] });
expect(listening['id'], equals(result['data'][0]['id']));
expect(listening['listening'], isTrue);
expect(listening['socketType'], equals('TCP'));
@@ -64,11 +65,11 @@ var tcpTests = [
expect(listening['remotePort'], equals('NA'));
var client = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][1]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][1]['id'] });
expect(client['id'], equals(result['data'][1]['id']));
var server = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][2]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][2]['id'] });
expect(server['id'], equals(result['data'][2]['id']));
// We expect the client to be connected on the port and
@@ -115,10 +116,10 @@ var tcpTests = [
}
var secondClient = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][3]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][3]['id'] });
expect(secondClient['id'], equals(result['data'][3]['id']));
var secondServer = await isolate.invokeRpcNoUpgrade(
- '__getSocketByID', { 'id' : result['data'][4]['id'] });
+ 'ext.dart.io.getSocketByID', { 'id' : result['data'][4]['id'] });
expect(secondServer['id'], equals(result['data'][4]['id']));
// We expect the client to be connected on the port and

Powered by Google App Engine
This is Rietveld 408576698