Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1680173002: Throw away everything in the go workspace except bin. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Throw away everything in the go workspace except bin. Looks like our win bots are having problems with .git files created by 'go get collidermain'. The test only requires the bin/ output, so nuke everything except that. BUG=585462 TBR=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/9cc3840d97e0ecd17319bb9e11344002fb8a7575

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build_apprtc_collider.py View 2 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
phoglund_chromium
4 years, 10 months ago (2016-02-09 15:57:30 UTC) #1
phoglund_chromium
Committed patchset #1 (id:1) manually as 9cc3840d97e0ecd17319bb9e11344002fb8a7575 (presubmit successful).
4 years, 10 months ago (2016-02-09 15:57:42 UTC) #3
kjellander_chromium
I think I might have spotted an error, but the bots also fail to do ...
4 years, 10 months ago (2016-02-09 16:27:29 UTC) #4
kjellander_chromium
4 years, 10 months ago (2016-02-09 20:55:59 UTC) #5
Message was sent while issue was closed.
On 2016/02/09 16:27:29, kjellander (chromium) wrote:
> I think I might have spotted an error, but the bots also fail to do rmtree :(
> See
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/build...
> I triggered that after this CL went in.
> 
> https://codereview.chromium.org/1680173002/diff/1/build_apprtc_collider.py
> File build_apprtc_collider.py (right):
> 
>
https://codereview.chromium.org/1680173002/diff/1/build_apprtc_collider.py#ne...
> build_apprtc_collider.py:48: shutil.rmtree(golang_workspace)
> If you remove src/out/go-workspace here, then trying to move the bin dir to
> src/out/go-workspace/bin below should fail, since shutil.move doesn't
re-create
> the src/out/go-workspace dir for you, I suppose?

I made a quick attempt in https://codereview.chromium.org/1686753002

Powered by Google App Engine
This is Rietveld 408576698