Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1686753002: Throw away everything in the go workspace except bin (2nd attempt). (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Throw away everything in the go workspace except bin (2nd attempt). Trying a more reliable way of deleting directories on Windows. The attempt in https://codereview.chromium.org/1680173002/ doesn't seem to help on the bots. BUG=585462 TBR=phoglund@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/60bf4ffbb0c08ed095e9310588d7c796b1127001

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build_apprtc_collider.py View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
kjellander_chromium
4 years, 10 months ago (2016-02-09 20:56:11 UTC) #1
kjellander_chromium
Committed patchset #1 (id:1) manually as 60bf4ffbb0c08ed095e9310588d7c796b1127001 (presubmit successful).
4 years, 10 months ago (2016-02-09 20:56:21 UTC) #3
phoglund_chromium
4 years, 10 months ago (2016-02-10 08:01:19 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1686753002/diff/1/build_apprtc_collider.py
File build_apprtc_collider.py (right):

https://codereview.chromium.org/1686753002/diff/1/build_apprtc_collider.py#ne...
build_apprtc_collider.py:49: os.makedirs(golang_workspace)
Oops! No, you're right, the move doesn't create dirs (but copytree does). Weird,
it worked locally for me. Thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698