Componentize FIND_IN_PAGE_* strings

Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.

TBR=jochen

Committed: https://crrev.com/b7bc3f131e0fc10962ecf7e9a3de48823eadbb4e
Cr-Commit-Position: refs/heads/master@{#374372}

[droger, 2016-02-09 11:32:13]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-02-09 11:53:01]

lgtm

https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
File chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm (right):

https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm:11: #include
"components/strings/grit/components_strings.h"
nit: it seems more common to include grit/components_strings.h in chrome/

[droger, 2016-02-09 12:14:30]

blundell: I think you know more about this, can you confirm that using
#include "components/strings/grit/components_strings.h"
should be preferred over:
#include "grit/components_strings.h"

Thanks

https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
File chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm (right):

https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm:11: #include
"components/strings/grit/components_strings.h"
On 2016/02/09 11:53:01, sdefresne wrote:
> nit: it seems more common to include grit/components_strings.h in chrome/

I'm pretty sure using the full path is the right way, and there is a bug to
convert all includes to use the full path:
https://code.google.com/p/chromium/issues/detail?id=401588

[blundell, 2016-02-09 12:15:14]

On 2016/02/09 12:14:30, droger wrote:
> blundell: I think you know more about this, can you confirm that using
> #include "components/strings/grit/components_strings.h"
> should be preferred over:
> #include "grit/components_strings.h"

Yes

> 
> Thanks
> 
>
https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
> File chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm (right):
> 
>
https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
> chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm:11: #include
> "components/strings/grit/components_strings.h"
> On 2016/02/09 11:53:01, sdefresne wrote:
> > nit: it seems more common to include grit/components_strings.h in chrome/
> 
> I'm pretty sure using the full path is the right way, and there is a bug to
> convert all includes to use the full path:
> https://code.google.com/p/chromium/issues/detail?id=401588

[sdefresne, 2016-02-09 12:41:36]

https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
File chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm (right):

https://codereview.chromium.org/1680113002/diff/1/chrome/browser/ui/cocoa/fin...
chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm:11: #include
"components/strings/grit/components_strings.h"
On 2016/02/09 at 12:14:30, droger wrote:
> On 2016/02/09 11:53:01, sdefresne wrote:
> > nit: it seems more common to include grit/components_strings.h in chrome/
> 
> I'm pretty sure using the full path is the right way, and there is a bug to
convert all includes to use the full path:
> https://code.google.com/p/chromium/issues/detail?id=401588

Thank you for the pointer. LGTM without comments then!

[droger, 2016-02-09 13:51:38]

Description was changed from

==========
Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.
==========

to

==========
Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.

TBR=jochen
==========

[droger, 2016-02-09 13:51:38]

droger@chromium.org changed reviewers:
+ jochen@chromium.org

[droger, 2016-02-09 13:51:59]

TBR=jochen for trivial include change in
chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

[droger, 2016-02-09 13:52:05]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2016-02-09 13:52:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680113002/1

[commit-bot: I haz the power, 2016-02-09 14:46:26]

Description was changed from

==========
Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.

TBR=jochen
==========

to

==========
Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.

TBR=jochen
==========

[commit-bot: I haz the power, 2016-02-09 14:46:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-09 14:47:35]

Description was changed from

==========
Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.

TBR=jochen
==========

to

==========
Componentize FIND_IN_PAGE_* strings

The strings are componentized to be shared with iOS builds.

TBR=jochen

Committed: https://crrev.com/b7bc3f131e0fc10962ecf7e9a3de48823eadbb4e
Cr-Commit-Position: refs/heads/master@{#374372}
==========

[commit-bot: I haz the power, 2016-02-09 14:47:36]

Patchset 1 (id:??) landed as
https://crrev.com/b7bc3f131e0fc10962ecf7e9a3de48823eadbb4e
Cr-Commit-Position: refs/heads/master@{#374372}