chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm - Issue 1680113002: Componentize FIND_IN_PAGE_* strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

Issue 1680113002: Componentize FIND_IN_PAGE_* strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

index 5942f2fdfe1e6296f69a942f6db3d04a162ccf3a..13c314ffe42f4c32e323ff8614f5163dc390730e 100644

--- a/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

@@ -8,7 +8,7 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/sys_string_conversions.h"

-#include "chrome/grit/generated_resources.h"

+#include "components/strings/grit/components_strings.h"

sdefresne 2016/02/09 11:53:01 nit: it seems more common to include grit/componen

droger 2016/02/09 12:14:30 I'm pretty sure using the full path is the right w

sdefresne 2016/02/09 12:41:36 Thank you for the pointer. LGTM without comments t

#include "ui/base/l10n/l10n_util.h"

namespace {

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/components_strings.grd » ('j') | no next file with comments »