Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm

Issue 1680113002: Componentize FIND_IN_PAGE_* strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/components_strings.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.h" 5 #import "chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
11 #include "chrome/grit/generated_resources.h" 11 #include "components/strings/grit/components_strings.h"
sdefresne 2016/02/09 11:53:01 nit: it seems more common to include grit/componen
droger 2016/02/09 12:14:30 I'm pretty sure using the full path is the right w
sdefresne 2016/02/09 12:41:36 Thank you for the pointer. LGTM without comments t
12 #include "ui/base/l10n/l10n_util.h" 12 #include "ui/base/l10n/l10n_util.h"
13 13
14 namespace { 14 namespace {
15 15
16 // How far to offset the keyword token into the field. 16 // How far to offset the keyword token into the field.
17 const NSInteger kResultsXOffset = 3; 17 const NSInteger kResultsXOffset = 3;
18 18
19 // How much width (beyond text) to add to the keyword token on each 19 // How much width (beyond text) to add to the keyword token on each
20 // side. 20 // side.
21 const NSInteger kResultsTokenInset = 3; 21 const NSInteger kResultsTokenInset = 3;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 [resultsString_.get() drawInRect:infoFrame]; 107 [resultsString_.get() drawInRect:infoFrame];
108 } 108 }
109 109
110 - (void)drawInteriorWithFrame:(NSRect)cellFrame inView:(NSView*)controlView { 110 - (void)drawInteriorWithFrame:(NSRect)cellFrame inView:(NSView*)controlView {
111 if (resultsString_) 111 if (resultsString_)
112 [self drawResultsWithFrame:cellFrame inView:controlView]; 112 [self drawResultsWithFrame:cellFrame inView:controlView];
113 [super drawInteriorWithFrame:cellFrame inView:controlView]; 113 [super drawInteriorWithFrame:cellFrame inView:controlView];
114 } 114 }
115 115
116 @end 116 @end
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/components_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698