Revert of Don't rely on the pending NavigationEntry for location.replace.

Revert of Don't rely on the pending NavigationEntry for location.replace. (patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate (https://crbug.com/585499) and RenderFrameImpl::willSendRequest (https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
>
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
>
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
Committed: https://crrev.com/ffdffc34e54051bd2397b33b7082dfc0a9af6ea1
Cr-Commit-Position: refs/heads/master@{#374430}

[Charlie Reis, 2016-02-09 19:11:51]

Created Revert of Don't rely on the pending NavigationEntry for
location.replace.

[commit-bot: I haz the power, 2016-02-09 19:12:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679383002/1

[commit-bot: I haz the power, 2016-02-09 19:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 19:20:18]

Failed to commit the patch.

[commit-bot: I haz the power, 2016-02-09 19:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[Charlie Reis, 2016-02-09 19:32:31]

Description was changed from

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
==========

to

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2016-02-09 19:33:02]

Description was changed from

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
==========

[Charlie Reis, 2016-02-09 19:33:51]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-02-09 19:35:40]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-02-09 19:35:45]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-02-09 19:38:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679383002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679383002/220001

[commit-bot: I haz the power, 2016-02-09 19:41:28]

Description was changed from

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
==========

to

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
==========

[commit-bot: I haz the power, 2016-02-09 19:41:29]

Committed patchset #2 (id:220001)

[commit-bot: I haz the power, 2016-02-09 19:42:24]

Description was changed from

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
> 
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
> 
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872
==========

to

==========
Revert of Don't rely on the pending NavigationEntry for location.replace.
(patchset #6 id:100001 of https://codereview.chromium.org/1672373002/ )

Reason for revert:
Causing crashes in NavigationControllerImpl::RendererDidNavigate
(https://crbug.com/585499) and RenderFrameImpl::willSendRequest
(https://crbug.com/585520).  Will investigate before re-landing.

Original issue's description:
> Don't rely on the pending NavigationEntry for location.replace.
>
> This CL adds a should_replace_current_entry param to commit IPCs,
> and it ensures the WebDataSource is accurate on browser-initiated
> navigations.  To keep the CL manageable, it does not yet change
> same-process location.replace navigations from EXISTING_PAGE to
> NEW_PAGE, though we want to do that as well.
>
> BUG=317872
> TEST=No behavior change.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/73c9e79d72b0781c3f22b5c61e95ba5170f4f4a1
> Cr-Commit-Position: refs/heads/master@{#374223}

TBR=avi@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=317872

Committed: https://crrev.com/ffdffc34e54051bd2397b33b7082dfc0a9af6ea1
Cr-Commit-Position: refs/heads/master@{#374430}
==========

[commit-bot: I haz the power, 2016-02-09 19:42:25]

Patchset 2 (id:??) landed as
https://crrev.com/ffdffc34e54051bd2397b33b7082dfc0a9af6ea1
Cr-Commit-Position: refs/heads/master@{#374430}