| Index: content/browser/frame_host/navigation_controller_impl.cc
|
| diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
|
| index 82260cc965085cef4bada6089da97407f2e3858e..a5034a515455b3df0c4578c452e9bc1d27d6d9d8 100644
|
| --- a/content/browser/frame_host/navigation_controller_impl.cc
|
| +++ b/content/browser/frame_host/navigation_controller_impl.cc
|
| @@ -847,19 +847,12 @@ bool NavigationControllerImpl::RendererDidNavigate(
|
| // If this is an error load, we may have already removed the pending entry
|
| // when we got the notice of the load failure. If so, look at the copy of the
|
| // pending parameters that were saved.
|
| - //
|
| - // TODO(creis): This block should be unnecessary now that we pass
|
| - // params.should_replace_current_entry. Remove it once we verify with the
|
| - // check below.
|
| if (params.url_is_unreachable && failed_pending_entry_id_ != 0) {
|
| details->did_replace_entry = failed_pending_entry_should_replace_;
|
| } else {
|
| details->did_replace_entry = pending_entry_ &&
|
| pending_entry_->should_replace_entry();
|
| }
|
| - CHECK(!details->did_replace_entry || params.should_replace_current_entry);
|
| - if (params.should_replace_current_entry)
|
| - details->did_replace_entry = true;
|
|
|
| // Do navigation-type specific actions. These will make and commit an entry.
|
| details->type = ClassifyNavigation(rfh, params);
|
| @@ -1004,18 +997,6 @@ NavigationType NavigationControllerImpl::ClassifyNavigation(
|
| return NAVIGATION_TYPE_NEW_SUBFRAME;
|
| }
|
|
|
| - // Cross-process location.replace navigations should be classified as New with
|
| - // replacement rather than ExistingPage, since it is not safe to reuse the
|
| - // NavigationEntry.
|
| - // TODO(creis): Have the renderer classify location.replace as
|
| - // did_create_new_entry for all cases and eliminate this special case. This
|
| - // requires updating several test expectations. See https://crbug.com/317872.
|
| - if (!rfh->GetParent() && GetLastCommittedEntry() &&
|
| - GetLastCommittedEntry()->site_instance() != rfh->GetSiteInstance() &&
|
| - params.should_replace_current_entry) {
|
| - return NAVIGATION_TYPE_NEW_PAGE;
|
| - }
|
| -
|
| // We only clear the session history when navigating to a new page.
|
| DCHECK(!params.history_list_was_cleared);
|
|
|
|
|