Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1678103004: [interpreter] Thread through language mode some more. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Thread through language mode some more. This threads the language mode from the bytecode to the node creation site in the bytecode graph builder. It only adapts the places where such threading is applicable without considering strong mode. The remaining uses of the language mode accessors are only required because of strong mode. R=mythria@chromium.org Committed: https://crrev.com/c507f9e111a8de7e05d86e66db4e4c78540d6e9c Cr-Commit-Position: refs/heads/master@{#33852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -50 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 6 chunks +22 lines, -46 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-09 14:13:25 UTC) #3
mythria
lgtm.
4 years, 10 months ago (2016-02-09 16:08:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678103004/1
4 years, 10 months ago (2016-02-09 16:30:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 16:42:32 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 16:42:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c507f9e111a8de7e05d86e66db4e4c78540d6e9c
Cr-Commit-Position: refs/heads/master@{#33852}

Powered by Google App Engine
This is Rietveld 408576698