Add insert/extract element to the integrated ARM assembler.

Add insert/extract element to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6de32b2199915462a4216399ff0f3af31ec88015

[Karl, 2016-02-10 20:17:52]

Description was changed from

==========
Add insert/extract element to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add insert/extract element to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-02-10 20:17:52]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[John, 2016-02-10 20:25:38]

lgtm

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1028: IValueT Rt = encodeGPRegister(OpRt, "Rt",
InstName);
const

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1043: Dn = Dn + mask(Index, 3, 1);
perhaps | instead of +?

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2820: IValueT Sd = encodeSRegister(OpSd, "Sd",
Vmovsqi);
const

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2822: IValueT Sm = mapQRegToSReg(encodeQRegister(OpQm,
"Qm", Vmovsqi)) + Index;
const

[Karl, 2016-02-10 21:30:51]

Description was changed from

==========
Add insert/extract element to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add insert/extract element to the integrated ARM assembler.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-02-10 21:30:52]

Committed patchset #3 (id:40001) manually as
6de32b2199915462a4216399ff0f3af31ec88015 (presubmit successful).

[Karl, 2016-02-10 21:31:03]

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1028: IValueT Rt = encodeGPRegister(OpRt, "Rt",
InstName);
On 2016/02/10 20:25:38, John wrote:
> const

Done.

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1043: Dn = Dn + mask(Index, 3, 1);
On 2016/02/10 20:25:38, John wrote:
> perhaps | instead of +?

Actually, we want an add here. We increment Dn to the right register, based on
the index value.

Then again, since there are only two registers, using | makes sense. Changing to
|.

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2820: IValueT Sd = encodeSRegister(OpSd, "Sd",
Vmovsqi);
On 2016/02/10 20:25:38, John wrote:
> const

Done.

https://codereview.chromium.org/1679023008/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2822: IValueT Sm = mapQRegToSReg(encodeQRegister(OpQm,
"Qm", Vmovsqi)) + Index;
On 2016/02/10 20:25:38, John wrote:
> const

Done.