Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1678923003: Rename ServiceConnector to InterfaceBinder. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@connection
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ServiceConnector to InterfaceBinder. Also fixes a subtle bug introduced with my ServiceConnectorRegistry removal... the default binder must only be consulted when no registered binder exists for the interface name. R=rockot@chromium.org BUG= Committed: https://crrev.com/3fff9403b5cf1e1d65ff18f059f4cb9eb0203d2f Cr-Commit-Position: refs/heads/master@{#374273}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -167 lines) Patch
M components/html_viewer/html_document_application_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 2 3 7 chunks +19 lines, -18 lines 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 5 chunks +10 lines, -10 lines 0 comments Download
A mojo/shell/public/cpp/interface_binder.h View 1 chunk +30 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 4 chunks +13 lines, -13 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 1 5 chunks +23 lines, -31 lines 0 comments Download
A mojo/shell/public/cpp/lib/interface_factory_binder.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
D mojo/shell/public/cpp/lib/interface_factory_connector.h View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/shell/public/cpp/service_connector.h View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/shell/public/cpp/tests/connection_impl_unittest.cc View 4 chunks +15 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (9 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-08 20:30:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678923003/20001
4 years, 10 months ago (2016-02-08 20:36:00 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/140479)
4 years, 10 months ago (2016-02-08 21:12:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678923003/40001
4 years, 10 months ago (2016-02-08 23:04:36 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/47296) linux_chromium_rel_ng on ...
4 years, 10 months ago (2016-02-08 23:29:19 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678923003/60001
4 years, 10 months ago (2016-02-09 00:18:00 UTC) #11
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-09 01:11:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678923003/60001
4 years, 10 months ago (2016-02-09 02:15:38 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-09 02:25:47 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 02:26:53 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3fff9403b5cf1e1d65ff18f059f4cb9eb0203d2f
Cr-Commit-Position: refs/heads/master@{#374273}

Powered by Google App Engine
This is Rietveld 408576698