Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1675153002: ApplicationImpl->ShellConnection, mojom::Application->mojom::ShellClient (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, jochen+watch_chromium.org, kalyank, mlamouri+watch-test-runner_chromium.org, penghuang+watch-mandoline_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ci2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ApplicationImpl->ShellConnection mojom::Application->mojom::ShellClient R=rockot@chromium.org BUG= Committed: https://crrev.com/d3a4bc09b9692bf6165aa9390d057830466743a5 Cr-Commit-Position: refs/heads/master@{#374259}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -837 lines) Patch
M components/filesystem/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/content_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/content_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_document.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_document_application_delegate.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/layout_test_content_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/layout_test_content_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/android_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/android_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/process_control_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/process_control_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M content/common/process_control.mojom View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mandoline/services/updater/updater_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/updater/updater_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/common/mus_views_init.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mash/example/window_type_launcher/main.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_instance.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/application_instance.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/application_loader.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/application_manager.h View 1 3 chunks +9 lines, -10 lines 0 comments Download
M mojo/shell/application_manager.cc View 7 chunks +14 lines, -15 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 8 chunks +10 lines, -10 lines 0 comments Download
M mojo/shell/application_package_apptest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/background/background_shell.h View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/background/background_shell.cc View 1 2 3 4 5 4 chunks +12 lines, -12 lines 0 comments Download
M mojo/shell/capability_filter_test.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/fetcher/about_fetcher_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/native_runner.h View 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/shell/package_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/package_manager/capability_filter_content_handler_unittest.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/shell/package_manager/content_handler_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/content_handler_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/content_handler_unittest.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/shell/package_manager/package_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/package_manager_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/app_lifetime_helper.h View 3 chunks +5 lines, -5 lines 0 comments Download
D mojo/shell/public/cpp/application_impl.h View 1 chunk +0 lines, -145 lines 0 comments Download
M mojo/shell/public/cpp/application_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/application_test_base.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/content_handler_factory.h View 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/app_lifetime_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/shell/public/cpp/lib/application_impl.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 6 chunks +31 lines, -32 lines 0 comments Download
M mojo/shell/public/cpp/lib/content_handler_factory.cc View 5 chunks +11 lines, -12 lines 0 comments Download
A + mojo/shell/public/cpp/lib/shell_connection.cc View 9 chunks +26 lines, -26 lines 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/public/cpp/shell_connection.h View 1 4 chunks +26 lines, -32 lines 0 comments Download
M mojo/shell/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/public/interfaces/application.mojom View 1 chunk +0 lines, -75 lines 0 comments Download
M mojo/shell/public/interfaces/content_handler.mojom View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/shell/public/interfaces/shell_client.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/runner/child/child_controller.mojom View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/child/runner_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/child/runner_connection.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M mojo/shell/runner/child/test_native_main.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/child/test_native_main.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M mojo/shell/runner/host/child_process.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/runner/host/in_process_native_runner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/runner/host/in_process_native_runner.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/runner/host/native_application_support.h View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/native_application_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/shell_application_loader.h View 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/shell/shell_application_loader.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/standalone/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/android_handler.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/standalone/android/android_handler_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/standalone/android/android_handler_loader.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/shell/standalone/android/background_application_loader.h View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/standalone/android/background_application_loader.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M mojo/shell/standalone/android/background_application_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/android/ui_application_loader_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/android/ui_application_loader_android.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M mojo/shell/static_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/static_application_loader.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/test_package_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/test_package_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 31 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675153002/40001
4 years, 10 months ago (2016-02-08 06:16:53 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/153556) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 10 months ago (2016-02-08 06:20:54 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675153002/60001
4 years, 10 months ago (2016-02-08 06:30:47 UTC) #7
Ken Rockot(use gerrit already)
*confused stare* oh you mean ApplicationImpl->ShellConnection lgtm :)
4 years, 10 months ago (2016-02-08 07:22:29 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/142205)
4 years, 10 months ago (2016-02-08 07:33:24 UTC) #10
Ben Goodger (Google)
On 2016/02/08 07:22:29, Ken Rockot wrote: > *confused stare* > > oh you mean ApplicationImpl->ShellConnection ...
4 years, 10 months ago (2016-02-08 15:32:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675153002/80001
4 years, 10 months ago (2016-02-08 15:35:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/143699)
4 years, 10 months ago (2016-02-08 15:47:14 UTC) #17
Ben Goodger (Google)
jschuh: process_control.mojom (renamed a parameter)
4 years, 10 months ago (2016-02-08 18:59:26 UTC) #19
jschuh
Rubberstamp lgtm for ipc: simple rename
4 years, 10 months ago (2016-02-08 19:03:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675153002/80001
4 years, 10 months ago (2016-02-08 19:15:18 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/143795)
4 years, 10 months ago (2016-02-08 19:42:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675153002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675153002/100001
4 years, 10 months ago (2016-02-08 23:04:33 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-09 01:43:21 UTC) #29
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 01:44:53 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d3a4bc09b9692bf6165aa9390d057830466743a5
Cr-Commit-Position: refs/heads/master@{#374259}

Powered by Google App Engine
This is Rietveld 408576698