sync: Improve StatusChangeChecker debug strings

sync: Improve StatusChangeChecker debug strings

Moves the definition of the "Await*" methods' sources into the
StatusChangeChecker.  This allows the removal of some code that had
overlapping responsibilities and the creation of more informative debug
messages.

BUG=323380
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252231

[rlarocque, 2014-02-14 23:19:06]

Here's a small patch to improve some debug messages and the code that implements
them.

This is the first patch of a larger stack:
https://codereview.chromium.org/165393010/

Please review.

[tim (not reviewing), 2014-02-18 19:25:44]

LGTM with nit.

https://codereview.chromium.org/167873002/diff/1/chrome/browser/sync/test/int...
File chrome/browser/sync/test/integration/sync_errors_test.cc (right):

https://codereview.chromium.org/167873002/diff/1/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/sync_errors_test.cc:50: return
"ActionableErrorChecker";
uber nit - might be nice to try to stick to a simple pattern so we can look at
log spew and immediately know which part is complaining e.g 

"StatusChangeChecker: Waiting for auth error."
"StatusChangeChecker: Waiting for actionable error."
"StatusChangeChecker:  <exponential backoff blah blah...>

(I think "waiting for auth error" is pretty generic / could come from anywhere,
for example.)

[rlarocque, 2014-02-18 20:51:47]

On 2014/02/18 19:25:44, timsteele wrote:
> LGTM with nit.
> 
>
https://codereview.chromium.org/167873002/diff/1/chrome/browser/sync/test/int...
> File chrome/browser/sync/test/integration/sync_errors_test.cc (right):
> 
>
https://codereview.chromium.org/167873002/diff/1/chrome/browser/sync/test/int...
> chrome/browser/sync/test/integration/sync_errors_test.cc:50: return
> "ActionableErrorChecker";
> uber nit - might be nice to try to stick to a simple pattern so we can look at
> log spew and immediately know which part is complaining e.g 
> 
> "StatusChangeChecker: Waiting for auth error."
> "StatusChangeChecker: Waiting for actionable error."
> "StatusChangeChecker:  <exponential backoff blah blah...>
> 
> (I think "waiting for auth error" is pretty generic / could come from
anywhere,
> for example.)

It's not intended to be printed directly.  I don't expect anyone would write
'LOG(INFO) << checker.GetDebugMessage()'.

The current call sites have the message wrapped in a call to
ProfileSyncServiceHarness::GetClientInfoString().  I think we should continue to
leave it up to the call sites to provide the appropriate context for the
message.

[rlarocque, 2014-02-19 19:25:16]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-02-19 19:38:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167873002/1

[commit-bot: I haz the power, 2014-02-20 00:03:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167873002/1

[commit-bot: I haz the power, 2014-02-20 01:17:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167873002/1

[commit-bot: I haz the power, 2014-02-20 05:05:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167873002/1

[commit-bot: I haz the power, 2014-02-20 09:01:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167873002/1

[commit-bot: I haz the power, 2014-02-20 12:25:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167873002/1

[commit-bot: I haz the power, 2014-02-20 14:01:48]

Change committed as 252231