chrome/browser/sync/test/integration/profile_sync_service_harness.h - Issue 167873002: sync: Improve StatusChangeChecker debug strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/profile_sync_service_harness.h

Issue 167873002: sync: Improve StatusChangeChecker debug strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/migration_test.cc ('k') | chrome/browser/sync/test/integration/profile_sync_service_harness.cc » ('j') | chrome/browser/sync/test/integration/sync_errors_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/profile_sync_service_harness.h

diff --git a/chrome/browser/sync/test/integration/profile_sync_service_harness.h b/chrome/browser/sync/test/integration/profile_sync_service_harness.h

index ee3c728fd321bb6333beefa86f70be99308f05a6..f8a55d69797d87baea5039139c50204e68be364c 100644

--- a/chrome/browser/sync/test/integration/profile_sync_service_harness.h

+++ b/chrome/browser/sync/test/integration/profile_sync_service_harness.h

@@ -182,9 +182,8 @@ class ProfileSyncServiceHarness

// returns true, indicating that the status change we are waiting for has

// taken place. Caller retains ownership of |checker|, which must outlive this

// method. Returns true if the status change was observed. In case of a

- // timeout, we log the |source| of the call to this method, and return false.

- bool AwaitStatusChange(StatusChangeChecker* checker,

- const std::string& source);

+ // timeout, we CHECK(false).

+ bool AwaitStatusChange(StatusChangeChecker* checker);

// Returns a string that can be used as the value of an oauth2 refresh token.

// This function guarantees that a different string is returned each time