sync: Improve StatusChangeChecker debug strings

chrome/browser/sync/test/integration/sync_errors_test.cc

Index: chrome/browser/sync/test/integration/sync_errors_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_errors_test.cc b/chrome/browser/sync/test/integration/sync_errors_test.cc
index 1e25a587bcf6078afa451c96a680a73402b594f4..72405bbdba5289aa346d1809db40f0e1a8c3669f 100644
--- a/chrome/browser/sync/test/integration/sync_errors_test.cc
+++ b/chrome/browser/sync/test/integration/sync_errors_test.cc
@@ -32,8 +32,7 @@ class SyncErrorTest : public SyncTest {
 class ActionableErrorChecker : public StatusChangeChecker {
  public:
   explicit ActionableErrorChecker(ProfileSyncService* service)
-      : StatusChangeChecker("ActionableErrorChecker"),
-        service_(service) {}
+      : service_(service) {}
 
   virtual ~ActionableErrorChecker() {}
 
@@ -47,6 +46,10 @@ class ActionableErrorChecker : public StatusChangeChecker {
             service_->HasUnrecoverableError());
   }
 
+  virtual std::string GetDebugMessage() const OVERRIDE {
+    return "ActionableErrorChecker";

[tim (not reviewing), 2014/02/18 19:25:44]

uber nit - might be nice to try to stick to a simple pattern so we can look at
log spew and immediately know which part is complaining e.g 

"StatusChangeChecker: Waiting for auth error."
"StatusChangeChecker: Waiting for actionable error."
"StatusChangeChecker:  <exponential backoff blah blah...>

(I think "waiting for auth error" is pretty generic / could come from anywhere,
for example.)

+  }
+
  private:
   // The PSS instance that will eventually hit an actionable error.
   ProfileSyncService* service_;
@@ -89,8 +92,7 @@ IN_PROC_BROWSER_TEST_F(SyncErrorTest, ActionableErrorTest) {
 
   // Wait until an actionable error is encountered.
   ActionableErrorChecker actionable_error_checker(GetClient(0)->service());
-  ASSERT_TRUE(GetClient(0)->AwaitStatusChange(&actionable_error_checker,
-                                              "Awaiting actionable error"));
+  ASSERT_TRUE(GetClient(0)->AwaitStatusChange(&actionable_error_checker));
 
   ProfileSyncService::Status status = GetClient(0)->GetStatus();
   ASSERT_EQ(status.sync_protocol_error.error_type, protocol_error.error_type);