Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1673893002: [trace-viewer] Removed monitoring mode (Closed)

Created:
4 years, 10 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 10 months ago
Reviewers:
nduca
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -650 lines) Patch
M tracing/trace_viewer.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/about_tracing/mock_tracing_controller_client.html View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/profiling_view.html View 1 10 chunks +3 lines, -126 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/profiling_view_test.html View 1 2 2 chunks +0 lines, -55 lines 0 comments Download
D tracing/tracing/ui/extras/about_tracing/record_and_capture_controller.html View 1 1 chunk +0 lines, -238 lines 0 comments Download
D tracing/tracing/ui/extras/about_tracing/record_and_capture_controller_test.html View 1 1 chunk +0 lines, -110 lines 0 comments Download
A + tracing/tracing/ui/extras/about_tracing/record_controller.html View 1 3 chunks +1 line, -58 lines 0 comments Download
A + tracing/tracing/ui/extras/about_tracing/record_controller_test.html View 1 2 2 chunks +1 line, -46 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
oystein (OOO til 10th of July)
ptal!
4 years, 10 months ago (2016-02-05 23:00:22 UTC) #1
nduca
lgtm though I think there's more to kill in record_and_capture_controller (and probably a renaming of ...
4 years, 10 months ago (2016-02-08 17:21:05 UTC) #2
oystein (OOO til 10th of July)
On 2016/02/08 17:21:05, nduca wrote: > lgtm though I think there's more to kill in ...
4 years, 10 months ago (2016-02-08 23:06:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673893002/40001
4 years, 10 months ago (2016-02-08 23:06:19 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 23:40:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698