Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: components/tracing/child_trace_message_filter.cc

Issue 1678503002: Tracing: Removed monitoring mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/child_trace_message_filter.h ('k') | components/tracing/tracing_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/child_trace_message_filter.cc
diff --git a/components/tracing/child_trace_message_filter.cc b/components/tracing/child_trace_message_filter.cc
index f0d76edb233ece40b311b5e4e89ced8ed5f93ad5..e11a915372379d4887091643970637d1500e87ce 100644
--- a/components/tracing/child_trace_message_filter.cc
+++ b/components/tracing/child_trace_message_filter.cc
@@ -50,10 +50,6 @@ bool ChildTraceMessageFilter::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(TracingMsg_BeginTracing, OnBeginTracing)
IPC_MESSAGE_HANDLER(TracingMsg_EndTracing, OnEndTracing)
IPC_MESSAGE_HANDLER(TracingMsg_CancelTracing, OnCancelTracing)
- IPC_MESSAGE_HANDLER(TracingMsg_StartMonitoring, OnStartMonitoring)
- IPC_MESSAGE_HANDLER(TracingMsg_StopMonitoring, OnStopMonitoring)
- IPC_MESSAGE_HANDLER(TracingMsg_CaptureMonitoringSnapshot,
- OnCaptureMonitoringSnapshot)
IPC_MESSAGE_HANDLER(TracingMsg_GetTraceLogStatus, OnGetTraceLogStatus)
IPC_MESSAGE_HANDLER(TracingMsg_SetWatchEvent, OnSetWatchEvent)
IPC_MESSAGE_HANDLER(TracingMsg_CancelWatchEvent, OnCancelWatchEvent)
@@ -107,28 +103,6 @@ void ChildTraceMessageFilter::OnCancelTracing() {
base::Bind(&ChildTraceMessageFilter::OnTraceDataCollected, this));
}
-void ChildTraceMessageFilter::OnStartMonitoring(
- const std::string& trace_config_str, base::TimeTicks browser_time) {
- TraceLog::GetInstance()->SetEnabled(
- base::trace_event::TraceConfig(trace_config_str),
- base::trace_event::TraceLog::MONITORING_MODE);
-}
-
-void ChildTraceMessageFilter::OnStopMonitoring() {
- TraceLog::GetInstance()->SetDisabled();
-}
-
-void ChildTraceMessageFilter::OnCaptureMonitoringSnapshot() {
- // Flush will generate one or more callbacks to
- // OnMonitoringTraceDataCollected. It's important that the last
- // OnMonitoringTraceDataCollected gets called before
- // CaptureMonitoringSnapshotAck below. We are already on the IO thread,
- // so the OnMonitoringTraceDataCollected calls will not be deferred.
- TraceLog::GetInstance()->FlushButLeaveBufferIntact(
- base::Bind(&ChildTraceMessageFilter::OnMonitoringTraceDataCollected,
- this));
-}
-
void ChildTraceMessageFilter::OnGetTraceLogStatus() {
sender_->Send(new TracingHostMsg_TraceLogStatusReply(
TraceLog::GetInstance()->GetStatus()));
@@ -175,23 +149,6 @@ void ChildTraceMessageFilter::OnTraceDataCollected(
}
}
-void ChildTraceMessageFilter::OnMonitoringTraceDataCollected(
- const scoped_refptr<base::RefCountedString>& events_str_ptr,
- bool has_more_events) {
- if (!ipc_task_runner_->BelongsToCurrentThread()) {
- ipc_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&ChildTraceMessageFilter::OnMonitoringTraceDataCollected,
- this, events_str_ptr, has_more_events));
- return;
- }
- sender_->Send(new TracingHostMsg_MonitoringTraceDataCollected(
- events_str_ptr->data()));
-
- if (!has_more_events)
- sender_->Send(new TracingHostMsg_CaptureMonitoringSnapshotAck());
-}
-
// Sent by the Browser's MemoryDumpManager when coordinating a global dump.
void ChildTraceMessageFilter::OnProcessMemoryDumpRequest(
const base::trace_event::MemoryDumpRequestArgs& args) {
« no previous file with comments | « components/tracing/child_trace_message_filter.h ('k') | components/tracing/tracing_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698