Subzero: Fix trailing whitespace errors.

Subzero: Fix trailing whitespace errors.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

Such changes are only in gen_arm32_reg_tables.py and IceInst.cpp.

There are lots of tab characters in .ll files that shouldn't be there, but fixing them would require some thought about how to do consistent formatting, so that's left for later.

BUG= none
R=eholk@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fbdc7e4cd0c2e217afb9310f0046fd456e7a07c1

[Jim Stichnoth, 2016-02-08 19:14:21]

Description was changed from

==========
Subzero: Fix trailing whitespace errors.

BUG= none
==========

to

==========
Subzero: Fix trailing whitespace errors.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

BUG= none
==========

[Jim Stichnoth, 2016-02-08 19:14:21]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Jim Stichnoth, 2016-02-08 19:17:09]

Description was changed from

==========
Subzero: Fix trailing whitespace errors.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

BUG= none
==========

to

==========
Subzero: Fix trailing whitespace errors.

There are lots of tab characters in .ll files that shouldn't be there, but
fixing them would require some thought about how to do consistent formatting, so
that's left for later.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

Such changes are only in gen_arm32_reg_tables.py and IceInst.cpp.

BUG= none
==========

[Jim Stichnoth, 2016-02-08 19:17:41]

Description was changed from

==========
Subzero: Fix trailing whitespace errors.

There are lots of tab characters in .ll files that shouldn't be there, but
fixing them would require some thought about how to do consistent formatting, so
that's left for later.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

Such changes are only in gen_arm32_reg_tables.py and IceInst.cpp.

BUG= none
==========

to

==========
Subzero: Fix trailing whitespace errors.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

Such changes are only in gen_arm32_reg_tables.py and IceInst.cpp.

There are lots of tab characters in .ll files that shouldn't be there, but
fixing them would require some thought about how to do consistent formatting, so
that's left for later.

BUG= none
==========

[Eric Holk, 2016-02-08 19:43:16]

lgtm

I've generally tried to avoid checking in auto-generated files and instead using
Makefiles to create/update as necessary. Is there a particular reason we don't
follow this pattern?

https://codereview.chromium.org/1678133003/diff/20001/pydir/gen_arm32_reg_tab...
File pydir/gen_arm32_reg_tables.py (right):

https://codereview.chromium.org/1678133003/diff/20001/pydir/gen_arm32_reg_tab...
pydir/gen_arm32_reg_tables.py:227: sys.stdout.write(' \\\n 
X({Reg})'.format(Reg=Reg))
Why did you change one to sys.stdout.write but not the others?

[Jim Stichnoth, 2016-02-08 23:39:22]

Reasons for checking in the auto-generated file:

1. The buildbot build system doesn't know about running the auto-generation
script.

2. It's often a bit easier to track the diffs in the auto-generated output,
which might be much harder to discern from changes in the script.

https://codereview.chromium.org/1678133003/diff/20001/pydir/gen_arm32_reg_tab...
File pydir/gen_arm32_reg_tables.py (right):

https://codereview.chromium.org/1678133003/diff/20001/pydir/gen_arm32_reg_tab...
pydir/gen_arm32_reg_tables.py:227: sys.stdout.write(' \\\n 
X({Reg})'.format(Reg=Reg))
On 2016/02/08 19:43:15, Eric Holk wrote:
> Why did you change one to sys.stdout.write but not the others?

The problem is:
  print 'foo', ; print 'bar'
prints 'foo bar'.  If you want to print on the same line, without an intervening
space, you have to do something like:
  sys.stdout.write('foo') ; print 'bar'

That said, I can't figure out why I don't end up with two spaces between
"#define ...TABLE" and the trailing backslash...

[Karl, 2016-02-09 21:31:14]

lgtm

[Jim Stichnoth, 2016-02-10 01:25:06]

Description was changed from

==========
Subzero: Fix trailing whitespace errors.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

Such changes are only in gen_arm32_reg_tables.py and IceInst.cpp.

There are lots of tab characters in .ll files that shouldn't be there, but
fixing them would require some thought about how to do consistent formatting, so
that's left for later.

BUG= none
==========

to

==========
Subzero: Fix trailing whitespace errors.

To view the non-whitespace changes in this CL:

  git cl patch -b testbranch 1678133003
  git diff -w --ignore-blank-lines -b master

Such changes are only in gen_arm32_reg_tables.py and IceInst.cpp.

There are lots of tab characters in .ll files that shouldn't be there, but
fixing them would require some thought about how to do consistent formatting, so
that's left for later.

BUG= none
R=eholk@chromium.org, kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-02-10 01:25:08]

Committed patchset #3 (id:40001) manually as
fbdc7e4cd0c2e217afb9310f0046fd456e7a07c1 (presubmit successful).