Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1677593003: Subzero: Improve an error message. (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth
Modified:
4 years, 10 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Improve an error message. Add the variable name and function name to the fatal error message. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=45bec54fdb3d6f6c48fc4f55fc56bdbf9dd3326e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/IceTargetLoweringARM32.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 10 months ago (2016-02-05 18:24:06 UTC) #3
Karl
lgtm
4 years, 10 months ago (2016-02-05 18:24:58 UTC) #4
Jim Stichnoth
4 years, 10 months ago (2016-02-05 18:26:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45bec54fdb3d6f6c48fc4f55fc56bdbf9dd3326e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698