Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 1677293002: Bye bye Mandoline (Closed)

Created:
3 years, 10 months ago by sky
Modified:
3 years, 10 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, sdefresne+watchlist_chromium.org, abarth-chromium, devtools-reviews_chromium.org, kalyank, jbudorick+watch_chromium.org, blundell+watchlist_chromium.org, dcheng, jochen+watch_chromium.org, rjkroege, mlamouri+watch-test-runner_chromium.org, tfarina, Aaron Boodman, mikecase+watch_chromium.org, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bye bye Mandoline This nukes mandoline, html_viewer and web-view. R=ben@chromium.org TEST=none Committed: https://crrev.com/fcde3a4bb26cd0037765be4128345f798247e0f1 Cr-Commit-Position: refs/heads/master@{#374453}

Patch Set 1 #

Patch Set 2 : extraneous #

Patch Set 3 : remove mandoline:all #

Patch Set 4 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22445 lines) Patch
M BUILD.gn View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M WATCHLISTS View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D components/html_viewer/BUILD.gn View 1 chunk +0 lines, -371 lines 0 comments Download
D components/html_viewer/DEPS View 1 chunk +0 lines, -71 lines 0 comments Download
D components/html_viewer/OWNERS View 1 chunk +0 lines, -11 lines 0 comments Download
D components/html_viewer/ax_provider_apptest.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D components/html_viewer/ax_provider_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/html_viewer/ax_provider_impl.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D components/html_viewer/ax_provider_impl_unittest.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D components/html_viewer/blink_basic_type_converters.h View 1 chunk +0 lines, -59 lines 0 comments Download
D components/html_viewer/blink_basic_type_converters.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D components/html_viewer/blink_find_type_converters.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/html_viewer/blink_find_type_converters.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D components/html_viewer/blink_platform_impl.h View 1 chunk +0 lines, -126 lines 0 comments Download
D components/html_viewer/blink_platform_impl.cc View 1 chunk +0 lines, -310 lines 0 comments Download
D components/html_viewer/blink_resource_constants.h View 1 chunk +0 lines, -114 lines 0 comments Download
D components/html_viewer/blink_settings.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/html_viewer/blink_settings.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/html_viewer/blink_settings_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/html_viewer/blink_settings_impl.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D components/html_viewer/blink_text_input_type_converters.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/html_viewer/blink_text_input_type_converters.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D components/html_viewer/blink_url_request_type_converters.h View 1 chunk +0 lines, -23 lines 0 comments Download
D components/html_viewer/blink_url_request_type_converters.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D components/html_viewer/content_handler_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/html_viewer/content_handler_impl.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D components/html_viewer/devtools_agent_impl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D components/html_viewer/devtools_agent_impl.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D components/html_viewer/discardable_memory_allocator.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/html_viewer/discardable_memory_allocator.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D components/html_viewer/discardable_memory_allocator_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D components/html_viewer/document_resource_waiter.h View 1 chunk +0 lines, -141 lines 0 comments Download
D components/html_viewer/document_resource_waiter.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D components/html_viewer/generate_blink_resource_map.py View 1 chunk +0 lines, -146 lines 0 comments Download
D components/html_viewer/geolocation_client_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D components/html_viewer/geolocation_client_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D components/html_viewer/global_state.h View 1 chunk +0 lines, -143 lines 0 comments Download
D components/html_viewer/global_state.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D components/html_viewer/html_document.h View 1 chunk +0 lines, -179 lines 0 comments Download
D components/html_viewer/html_document.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D components/html_viewer/html_document_application_delegate.h View 1 chunk +0 lines, -90 lines 0 comments Download
D components/html_viewer/html_document_application_delegate.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D components/html_viewer/html_factory.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/html_viewer/html_frame.h View 1 chunk +0 lines, -389 lines 0 comments Download
D components/html_viewer/html_frame.cc View 1 chunk +0 lines, -1050 lines 0 comments Download
D components/html_viewer/html_frame_apptest.cc View 1 chunk +0 lines, -492 lines 0 comments Download
D components/html_viewer/html_frame_delegate.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/html_viewer/html_frame_properties.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/html_viewer/html_frame_properties.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D components/html_viewer/html_frame_tree_manager.h View 1 chunk +0 lines, -150 lines 0 comments Download
D components/html_viewer/html_frame_tree_manager.cc View 1 chunk +0 lines, -411 lines 0 comments Download
D components/html_viewer/html_frame_tree_manager_observer.h View 1 chunk +0 lines, -26 lines 0 comments Download
D components/html_viewer/html_viewer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/html_viewer/html_viewer.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D components/html_viewer/html_viewer_main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/html_viewer/html_viewer_resources.grd View 1 chunk +0 lines, -10 lines 0 comments Download
D components/html_viewer/html_viewer_version.rc View 1 chunk +0 lines, -46 lines 0 comments Download
D components/html_viewer/html_widget.h View 1 chunk +0 lines, -142 lines 0 comments Download
D components/html_viewer/html_widget.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D components/html_viewer/ime_controller.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/html_viewer/ime_controller.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D components/html_viewer/input_events_unittest.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D components/html_viewer/layout_test_blink_settings_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/html_viewer/layout_test_blink_settings_impl.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D components/html_viewer/layout_test_content_handler_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/html_viewer/layout_test_content_handler_impl.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D components/html_viewer/layout_test_html_viewer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D components/html_viewer/layout_test_html_viewer.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D components/html_viewer/layout_test_html_viewer_main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/html_viewer/media_factory.h View 1 chunk +0 lines, -103 lines 0 comments Download
D components/html_viewer/media_factory.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D components/html_viewer/mock_web_blob_registry_impl.h View 1 chunk +0 lines, -67 lines 0 comments Download
D components/html_viewer/mock_web_blob_registry_impl.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D components/html_viewer/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/html_viewer/public/interfaces/test_html_viewer.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D components/html_viewer/replicated_frame_state.h View 1 chunk +0 lines, -44 lines 0 comments Download
D components/html_viewer/replicated_frame_state.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D components/html_viewer/run_all_unittests.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D components/html_viewer/stats_collection_controller.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/html_viewer/stats_collection_controller.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D components/html_viewer/test_blink_platform_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/html_viewer/test_blink_platform_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D components/html_viewer/test_html_viewer_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/html_viewer/test_html_viewer_impl.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D components/html_viewer/touch_handler.h View 1 chunk +0 lines, -60 lines 0 comments Download
D components/html_viewer/touch_handler.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D components/html_viewer/web_clipboard_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/html_viewer/web_clipboard_impl.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D components/html_viewer/web_cookie_jar_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/html_viewer/web_cookie_jar_impl.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D components/html_viewer/web_graphics_context_3d_command_buffer_impl.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D components/html_viewer/web_layer_tree_view_impl.h View 1 chunk +0 lines, -126 lines 0 comments Download
D components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D components/html_viewer/web_mime_registry_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D components/html_viewer/web_mime_registry_impl.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D components/html_viewer/web_notification_manager_impl.h View 1 chunk +0 lines, -55 lines 0 comments Download
D components/html_viewer/web_notification_manager_impl.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D components/html_viewer/web_preferences.h View 1 chunk +0 lines, -230 lines 0 comments Download
D components/html_viewer/web_preferences.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D components/html_viewer/web_socket_handle_impl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D components/html_viewer/web_socket_handle_impl.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D components/html_viewer/web_storage_namespace_impl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/html_viewer/web_storage_namespace_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D components/html_viewer/web_test_delegate_impl.h View 1 chunk +0 lines, -142 lines 0 comments Download
D components/html_viewer/web_test_delegate_impl.cc View 1 chunk +0 lines, -372 lines 0 comments Download
D components/html_viewer/web_theme_engine_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/html_viewer/web_theme_engine_impl.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D components/html_viewer/web_url_loader_impl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D components/html_viewer/web_url_loader_impl.cc View 1 chunk +0 lines, -324 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
D components/pdf_viewer/BUILD.gn View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
D components/pdf_viewer/DEPS View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D components/pdf_viewer/OWNERS View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
D components/pdf_viewer/pdf_viewer.cc View 1 2 3 1 chunk +0 lines, -380 lines 0 comments Download
D components/web_view/BUILD.gn View 1 chunk +0 lines, -138 lines 0 comments Download
D components/web_view/DEPS View 1 chunk +0 lines, -17 lines 0 comments Download
D components/web_view/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/web_view/client_initiated_frame_connection.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/web_view/client_initiated_frame_connection.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D components/web_view/find_controller.h View 1 chunk +0 lines, -110 lines 0 comments Download
D components/web_view/find_controller.cc View 1 chunk +0 lines, -238 lines 0 comments Download
D components/web_view/find_controller_delegate.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/web_view/frame.h View 1 chunk +0 lines, -294 lines 0 comments Download
D components/web_view/frame.cc View 1 chunk +0 lines, -609 lines 0 comments Download
D components/web_view/frame_apptest.cc View 1 chunk +0 lines, -579 lines 0 comments Download
D components/web_view/frame_connection.h View 1 chunk +0 lines, -73 lines 0 comments Download
D components/web_view/frame_connection.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D components/web_view/frame_devtools_agent.h View 1 chunk +0 lines, -84 lines 0 comments Download
D components/web_view/frame_devtools_agent.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D components/web_view/frame_devtools_agent_delegate.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/web_view/frame_tree.h View 1 chunk +0 lines, -100 lines 0 comments Download
D components/web_view/frame_tree.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D components/web_view/frame_tree_delegate.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/web_view/frame_tree_delegate.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D components/web_view/frame_user_data.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/web_view/frame_utils.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/web_view/frame_utils.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D components/web_view/local_find_options.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/web_view/local_find_options.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D components/web_view/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/web_view/navigation_controller.h View 1 chunk +0 lines, -95 lines 0 comments Download
D components/web_view/navigation_controller.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D components/web_view/navigation_controller_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
D components/web_view/navigation_entry.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/web_view/navigation_entry.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D components/web_view/pending_web_view_load.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/web_view/pending_web_view_load.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D components/web_view/public/cpp/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D components/web_view/public/cpp/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/web_view/public/cpp/web_view.h View 1 chunk +0 lines, -41 lines 0 comments Download
D components/web_view/public/cpp/web_view.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D components/web_view/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/web_view/public/interfaces/frame.mojom View 1 chunk +0 lines, -222 lines 0 comments Download
D components/web_view/public/interfaces/web_view.mojom View 1 chunk +0 lines, -57 lines 0 comments Download
D components/web_view/reload_type.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/web_view/test_frame_tree_delegate.h View 1 chunk +0 lines, -73 lines 0 comments Download
D components/web_view/test_frame_tree_delegate.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D components/web_view/test_runner/BUILD.gn View 1 chunk +0 lines, -67 lines 0 comments Download
D components/web_view/test_runner/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D components/web_view/test_runner/launcher.h View 1 chunk +0 lines, -15 lines 0 comments Download
D components/web_view/test_runner/launcher.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D components/web_view/test_runner/main.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D components/web_view/test_runner/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/web_view/test_runner/public/interfaces/layout_test_runner.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D components/web_view/test_runner/register_local_aliases.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D components/web_view/test_runner/test_runner_application_delegate.h View 1 chunk +0 lines, -86 lines 0 comments Download
D components/web_view/test_runner/test_runner_application_delegate.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D components/web_view/test_runner/test_runner_main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/web_view/url_request_cloneable.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/web_view/url_request_cloneable.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D components/web_view/web_view_application_delegate.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/web_view/web_view_application_delegate.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D components/web_view/web_view_apptest.cc View 1 chunk +0 lines, -318 lines 0 comments Download
D components/web_view/web_view_impl.h View 1 chunk +0 lines, -142 lines 0 comments Download
D components/web_view/web_view_impl.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D components/web_view/web_view_switches.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/web_view/web_view_switches.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mandoline/BUILD.gn View 1 chunk +0 lines, -60 lines 0 comments Download
D mandoline/OWNERS View 1 chunk +0 lines, -11 lines 0 comments Download
D mandoline/README View 1 chunk +0 lines, -4 lines 0 comments Download
D mandoline/app/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D mandoline/app/android/BUILD.gn View 1 chunk +0 lines, -111 lines 0 comments Download
D mandoline/app/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mandoline/app/android/apk/AndroidManifest.xml View 1 chunk +0 lines, -42 lines 0 comments Download
D mandoline/app/android/apk/res/drawable/mandoline.png View Binary file 0 comments Download
D mandoline/app/android/apk/src/org/chromium/mandoline/MandolineActivity.java View 1 chunk +0 lines, -67 lines 0 comments Download
D mandoline/app/android/mandoline_activity.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D mandoline/app/android/mandoline_context_init.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D mandoline/app/desktop/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D mandoline/app/desktop/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mandoline/app/desktop/main.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D mandoline/app/register_local_aliases.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -79 lines 0 comments Download
D mandoline/services/core_services/DEPS View 1 chunk +0 lines, -16 lines 0 comments Download
D mandoline/services/core_services/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D mandoline/services/core_services/android_hooks.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D mandoline/services/core_services/application_delegate_factory.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mandoline/services/core_services/application_delegate_factory_default.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D mandoline/services/core_services/application_delegate_factory_linux.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D mandoline/services/core_services/application_delegate_factory_notandroid.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D mandoline/services/core_services/core_services_application_delegate.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mandoline/services/core_services/core_services_application_delegate.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D mandoline/services/core_services/main.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D mandoline/services/updater/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D mandoline/services/updater/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D mandoline/services/updater/updater_app.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mandoline/services/updater/updater_app.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D mandoline/services/updater/updater_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mandoline/services/updater/updater_impl.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D mandoline/tools/android/install_mandoline.py View 1 chunk +0 lines, -47 lines 0 comments Download
D mandoline/tools/android/run_mandoline.py View 1 chunk +0 lines, -90 lines 0 comments Download
D mandoline/tools/data/FILES.cfg View 1 chunk +0 lines, -63 lines 0 comments Download
D mandoline/ui/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mandoline/ui/common/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D mandoline/ui/common/resources/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mandoline/ui/desktop_ui/BUILD.gn View 1 chunk +0 lines, -74 lines 0 comments Download
D mandoline/ui/desktop_ui/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D mandoline/ui/desktop_ui/browser_apptest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D mandoline/ui/desktop_ui/browser_commands.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mandoline/ui/desktop_ui/browser_manager.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mandoline/ui/desktop_ui/browser_manager.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D mandoline/ui/desktop_ui/browser_window.h View 1 chunk +0 lines, -151 lines 0 comments Download
D mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +0 lines, -492 lines 0 comments Download
D mandoline/ui/desktop_ui/find_bar_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mandoline/ui/desktop_ui/find_bar_view.h View 1 chunk +0 lines, -60 lines 0 comments Download
D mandoline/ui/desktop_ui/find_bar_view.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D mandoline/ui/desktop_ui/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mandoline/ui/desktop_ui/public/interfaces/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D mandoline/ui/desktop_ui/public/interfaces/launch_handler.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
D mandoline/ui/desktop_ui/public/interfaces/omnibox.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D mandoline/ui/desktop_ui/public/interfaces/view_embedder.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D mandoline/ui/desktop_ui/toolbar_view.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mandoline/ui/desktop_ui/toolbar_view.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mandoline/ui/omnibox/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D mandoline/ui/omnibox/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mandoline/ui/omnibox/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mandoline/ui/omnibox/omnibox_application.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mandoline/ui/omnibox/omnibox_application.cc View 1 chunk +0 lines, -235 lines 0 comments Download
D mandoline/ui/phone_ui/BUILD.gn View 1 chunk +0 lines, -40 lines 0 comments Download
D mandoline/ui/phone_ui/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mandoline/ui/phone_ui/main.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D mandoline/ui/phone_ui/phone_browser_application_delegate.h View 1 chunk +0 lines, -91 lines 0 comments Download
D mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M mash/wm/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/tools/data/apptests View 2 chunks +0 lines, -27 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 3 chunks +0 lines, -7 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 chunks +2 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sky
3 years, 10 months ago (2016-02-09 00:20:36 UTC) #2
sky
This time with the right Dirk. Dirk for testing changes Ben the rest
3 years, 10 months ago (2016-02-09 00:21:49 UTC) #5
Ben Goodger (Google)
haiku parse error 5-7-5 syllables better luck next time lgtm
3 years, 10 months ago (2016-02-09 00:25:05 UTC) #6
Dirk Pranke
lgtm
3 years, 10 months ago (2016-02-09 02:18:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677293002/60001
3 years, 10 months ago (2016-02-09 17:35:50 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 10 months ago (2016-02-09 20:27:55 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2016-02-09 20:29:01 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fcde3a4bb26cd0037765be4128345f798247e0f1
Cr-Commit-Position: refs/heads/master@{#374453}

Powered by Google App Engine
This is Rietveld 408576698