Stop using macros to paste together names for static_asserts.

Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
TBR=sievers,raymes
BUG=584474
Committed: https://crrev.com/365175c67f230c9f34c0be8580d9477daf0faa26
Cr-Commit-Position: refs/heads/master@{#373970}

[danakj, 2016-02-05 21:39:12]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 21:40:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676703002/1

[danakj, 2016-02-05 21:40:30]

danakj@chromium.org changed reviewers:
+ caitkp@google.com, raymes@chromium.org, sievers@chromium.org,
thestig@chromium.org

[danakj, 2016-02-05 21:40:30]

+sievers for content/
+thestig for pdf/
+raymes for ppapi/
+caitkp for components/

[danakj, 2016-02-05 21:40:49]

danakj@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[danakj, 2016-02-05 21:40:50]

+dalecurtis for media/

[Nico, 2016-02-05 21:48:51]

I was about to write "we should make the tool better instead", but this change
looks very reasonable independent of the tool, so lgtm :-)

(the .mm change does look a bit worse, but in return it's now consistent with
_all the other enum checks_, and that's worth something too)

[DaleCurtis, 2016-02-05 22:01:46]

media/ lgtm

[commit-bot: I haz the power, 2016-02-05 22:06:57]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[danakj, 2016-02-05 22:19:51]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 22:20:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676703002/20001

[commit-bot: I haz the power, 2016-02-05 22:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 22:25:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Lei Zhang, 2016-02-05 22:48:08]

On 2016/02/05 21:40:30, danakj wrote:
> +sievers for content/
> +thestig for pdf/
> +raymes for ppapi/
> +caitkp for components/

components/printing/ and pdf/ lgtm

[danakj, 2016-02-05 22:48:57]

Description was changed from

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
BUG=584474
==========

to

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
BUG=584474
==========

[danakj, 2016-02-05 22:48:57]

danakj@chromium.org changed reviewers:
- caitkp@google.com

[danakj, 2016-02-05 22:53:25]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 22:55:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676703002/80001

[danakj, 2016-02-05 23:32:43]

Description was changed from

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
BUG=584474
==========

to

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
TBR=sievers,raymes
BUG=584474
==========

[danakj, 2016-02-05 23:35:13]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-02-05 23:35:24]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-05 23:35:25]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
dalecurtis@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1676703002/#ps80001
(title: "static-asserts-enums: a,b,#a")

[commit-bot: I haz the power, 2016-02-05 23:37:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676703002/80001

[commit-bot: I haz the power, 2016-02-06 00:37:46]

Description was changed from

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
TBR=sievers,raymes
BUG=584474
==========

to

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
TBR=sievers,raymes
BUG=584474
==========

[commit-bot: I haz the power, 2016-02-06 00:37:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-06 00:40:07]

Description was changed from

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
TBR=sievers,raymes
BUG=584474
==========

to

==========
Stop using macros to paste together names for static_asserts.

This unifies all the static assert macros to be:
- Named STATIC_ASSERT_ENUM
- Use static_cast<int>() instead of other disallowed casts.
- Take the full enum name as an input so that code search and rewriter
  tools etc can find the actual thing being done by the code.

This will allow the rewrite_to_chrome_style tool to change blink enum
names and fix these places up too so things compile.

R=thakis@chromium.org
TBR=sievers,raymes
BUG=584474

Committed: https://crrev.com/365175c67f230c9f34c0be8580d9477daf0faa26
Cr-Commit-Position: refs/heads/master@{#373970}
==========

[commit-bot: I haz the power, 2016-02-06 00:40:08]

Patchset 5 (id:??) landed as
https://crrev.com/365175c67f230c9f34c0be8580d9477daf0faa26
Cr-Commit-Position: refs/heads/master@{#373970}