Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: content/child/appcache/appcache_frontend_impl.cc

Issue 1676703002: Stop using macros to paste together names for static_asserts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: static-asserts-enums: a,b,#a Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/appcache/appcache_frontend_impl.h" 5 #include "content/child/appcache/appcache_frontend_impl.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/child/appcache/web_application_cache_host_impl.h" 8 #include "content/child/appcache/web_application_cache_host_impl.h"
9 #include "third_party/WebKit/public/web/WebConsoleMessage.h" 9 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
10 10
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 void AppCacheFrontendImpl::OnContentBlocked(int host_id, 83 void AppCacheFrontendImpl::OnContentBlocked(int host_id,
84 const GURL& manifest_url) { 84 const GURL& manifest_url) {
85 WebApplicationCacheHostImpl* host = GetHost(host_id); 85 WebApplicationCacheHostImpl* host = GetHost(host_id);
86 if (host) 86 if (host)
87 host->OnContentBlocked(manifest_url); 87 host->OnContentBlocked(manifest_url);
88 } 88 }
89 89
90 // Ensure that enum values never get out of sync with the 90 // Ensure that enum values never get out of sync with the
91 // ones declared for use within the WebKit api 91 // ones declared for use within the WebKit api
92 92
93 #define STATIC_ASSERT_ENUM(a, b, desc) \ 93 #define STATIC_ASSERT_ENUM(a, b) \
94 static_assert((int)a == (int)b, desc) 94 static_assert(static_cast<int>(a) == static_cast<int>(b), \
95 "mismatched enum: " #a)
95 96
96 // Confirm that WebApplicationCacheHost::<a> == APPCACHE_<b>. 97 STATIC_ASSERT_ENUM(WebApplicationCacheHost::Uncached, APPCACHE_STATUS_UNCACHED);
97 #define STATIC_ASSERT_WAC_ENUM(a, b) \ 98 STATIC_ASSERT_ENUM(WebApplicationCacheHost::Idle, APPCACHE_STATUS_IDLE);
98 STATIC_ASSERT_ENUM(WebApplicationCacheHost:: a, APPCACHE_##b, #a) 99 STATIC_ASSERT_ENUM(WebApplicationCacheHost::Checking, APPCACHE_STATUS_CHECKING);
100 STATIC_ASSERT_ENUM(WebApplicationCacheHost::Downloading,
101 APPCACHE_STATUS_DOWNLOADING);
102 STATIC_ASSERT_ENUM(WebApplicationCacheHost::UpdateReady,
103 APPCACHE_STATUS_UPDATE_READY);
104 STATIC_ASSERT_ENUM(WebApplicationCacheHost::Obsolete, APPCACHE_STATUS_OBSOLETE);
99 105
100 STATIC_ASSERT_WAC_ENUM(Uncached, STATUS_UNCACHED); 106 STATIC_ASSERT_ENUM(WebApplicationCacheHost::CheckingEvent,
101 STATIC_ASSERT_WAC_ENUM(Idle, STATUS_IDLE); 107 APPCACHE_CHECKING_EVENT);
102 STATIC_ASSERT_WAC_ENUM(Checking, STATUS_CHECKING); 108 STATIC_ASSERT_ENUM(WebApplicationCacheHost::ErrorEvent, APPCACHE_ERROR_EVENT);
103 STATIC_ASSERT_WAC_ENUM(Downloading, STATUS_DOWNLOADING); 109 STATIC_ASSERT_ENUM(WebApplicationCacheHost::NoUpdateEvent,
104 STATIC_ASSERT_WAC_ENUM(UpdateReady, STATUS_UPDATE_READY); 110 APPCACHE_NO_UPDATE_EVENT);
105 STATIC_ASSERT_WAC_ENUM(Obsolete, STATUS_OBSOLETE); 111 STATIC_ASSERT_ENUM(WebApplicationCacheHost::DownloadingEvent,
112 APPCACHE_DOWNLOADING_EVENT);
113 STATIC_ASSERT_ENUM(WebApplicationCacheHost::ProgressEvent,
114 APPCACHE_PROGRESS_EVENT);
115 STATIC_ASSERT_ENUM(WebApplicationCacheHost::UpdateReadyEvent,
116 APPCACHE_UPDATE_READY_EVENT);
117 STATIC_ASSERT_ENUM(WebApplicationCacheHost::CachedEvent, APPCACHE_CACHED_EVENT);
118 STATIC_ASSERT_ENUM(WebApplicationCacheHost::ObsoleteEvent,
119 APPCACHE_OBSOLETE_EVENT);
106 120
107 STATIC_ASSERT_WAC_ENUM(CheckingEvent, CHECKING_EVENT); 121 STATIC_ASSERT_ENUM(WebApplicationCacheHost::ManifestError,
108 STATIC_ASSERT_WAC_ENUM(ErrorEvent, ERROR_EVENT); 122 APPCACHE_MANIFEST_ERROR);
109 STATIC_ASSERT_WAC_ENUM(NoUpdateEvent, NO_UPDATE_EVENT); 123 STATIC_ASSERT_ENUM(WebApplicationCacheHost::SignatureError,
110 STATIC_ASSERT_WAC_ENUM(DownloadingEvent, DOWNLOADING_EVENT); 124 APPCACHE_SIGNATURE_ERROR);
111 STATIC_ASSERT_WAC_ENUM(ProgressEvent, PROGRESS_EVENT); 125 STATIC_ASSERT_ENUM(WebApplicationCacheHost::ResourceError,
112 STATIC_ASSERT_WAC_ENUM(UpdateReadyEvent, UPDATE_READY_EVENT); 126 APPCACHE_RESOURCE_ERROR);
113 STATIC_ASSERT_WAC_ENUM(CachedEvent, CACHED_EVENT); 127 STATIC_ASSERT_ENUM(WebApplicationCacheHost::ChangedError,
114 STATIC_ASSERT_WAC_ENUM(ObsoleteEvent, OBSOLETE_EVENT); 128 APPCACHE_CHANGED_ERROR);
129 STATIC_ASSERT_ENUM(WebApplicationCacheHost::AbortError, APPCACHE_ABORT_ERROR);
130 STATIC_ASSERT_ENUM(WebApplicationCacheHost::QuotaError, APPCACHE_QUOTA_ERROR);
131 STATIC_ASSERT_ENUM(WebApplicationCacheHost::PolicyError, APPCACHE_POLICY_ERROR);
132 STATIC_ASSERT_ENUM(WebApplicationCacheHost::UnknownError,
133 APPCACHE_UNKNOWN_ERROR);
115 134
116 STATIC_ASSERT_WAC_ENUM(ManifestError, MANIFEST_ERROR); 135 STATIC_ASSERT_ENUM(WebConsoleMessage::LevelDebug, APPCACHE_LOG_DEBUG);
117 STATIC_ASSERT_WAC_ENUM(SignatureError, SIGNATURE_ERROR); 136 STATIC_ASSERT_ENUM(WebConsoleMessage::LevelLog, APPCACHE_LOG_INFO);
118 STATIC_ASSERT_WAC_ENUM(ResourceError, RESOURCE_ERROR); 137 STATIC_ASSERT_ENUM(WebConsoleMessage::LevelWarning, APPCACHE_LOG_WARNING);
119 STATIC_ASSERT_WAC_ENUM(ChangedError, CHANGED_ERROR); 138 STATIC_ASSERT_ENUM(WebConsoleMessage::LevelError, APPCACHE_LOG_ERROR);
120 STATIC_ASSERT_WAC_ENUM(AbortError, ABORT_ERROR);
121 STATIC_ASSERT_WAC_ENUM(QuotaError, QUOTA_ERROR);
122 STATIC_ASSERT_WAC_ENUM(PolicyError, POLICY_ERROR);
123 STATIC_ASSERT_WAC_ENUM(UnknownError, UNKNOWN_ERROR);
124
125 // Confirm that WebConsoleMessage::<a> == APPCACHE_<b>.
126 #define STATIC_ASSERT_WCM_ENUM(a, b) \
127 STATIC_ASSERT_ENUM(WebConsoleMessage:: a, APPCACHE_##b, #a)
128
129 STATIC_ASSERT_WCM_ENUM(LevelDebug, LOG_DEBUG);
130 STATIC_ASSERT_WCM_ENUM(LevelLog, LOG_INFO);
131 STATIC_ASSERT_WCM_ENUM(LevelWarning, LOG_WARNING);
132 STATIC_ASSERT_WCM_ENUM(LevelError, LOG_ERROR);
133 139
134 } // namespace content 140 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_view_mac.mm ('k') | content/child/assert_matching_enums.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698