ppapi/thunk/ppb_text_input_thunk.cc - Issue 1676703002: Stop using macros to paste together names for static_asserts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/thunk/ppb_text_input_thunk.cc

Issue 1676703002: Stop using macros to paste together names for static_asserts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: static-asserts-enums: a,b,#a Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pdf/pdfium/pdfium_assert_matching_enums.cc ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/thunk/ppb_text_input_thunk.cc

diff --git a/ppapi/thunk/ppb_text_input_thunk.cc b/ppapi/thunk/ppb_text_input_thunk.cc

index 030a7f57951bca1d0891c147c6ba194077d504ff..c376ce0e9d4d0714aec4332f4a6a537cdb169c87 100644

--- a/ppapi/thunk/ppb_text_input_thunk.cc

+++ b/ppapi/thunk/ppb_text_input_thunk.cc

@@ -16,8 +16,9 @@ namespace thunk {

namespace {

-#define STATIC_ASSERT_ENUM(a, b) \

- static_assert(int(a) == int(b), "mismatching enum values: " #a)

+#define STATIC_ASSERT_ENUM(a, b) \

+ static_assert(static_cast<int>(a) == static_cast<int>(b), \

+ "mismatching enum: " #a)

STATIC_ASSERT_ENUM(PP_TEXTINPUT_TYPE_DEV_NONE, PP_TEXTINPUT_TYPE_NONE);

STATIC_ASSERT_ENUM(PP_TEXTINPUT_TYPE_DEV_TEXT, PP_TEXTINPUT_TYPE_TEXT);