gclient: add depot_tools to PATH

gclient: add depot_tools to PATH

BUG=437264
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298614

[Paweł Hajdan Jr., 2016-02-05 11:44:54]

phajdan.jr@chromium.org changed reviewers:
+ machenbach@chromium.org

[Paweł Hajdan Jr., 2016-02-05 11:44:54]

This fixes errors from
https://chromium-swarm-dev.appspot.com/user/task/2cca0add5362c710 :

________ running 'download_from_google_storage --bucket chromium-infra
--recursive --directory infra/appengine/milo' in '/tmp/kitchen-995290350'
Traceback (most recent call last):
  File "/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient.py",
line 2328, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient.py",
line 2314, in main
    return dispatcher.execute(OptionParser(), argv)
  File
"/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/subcommand.py",
line 252, in execute
    return command(parser, args[1:])
  File "/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient.py",
line 2148, in CMDrunhooks
    return client.RunOnDeps('runhooks', args)
  File "/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient.py",
line 1531, in RunOnDeps
    self.RunHooksRecursively(self._options)
  File "/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient.py",
line 985, in RunHooksRecursively
    hook, cwd=self.root.root_dir, always=True)
  File
"/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient_utils.py",
line 293, in CheckCallAndFilterAndHeader
    return CheckCallAndFilter(args, **kwargs)
  File
"/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/gclient_utils.py",
line 488, in CheckCallAndFilter
    **kwargs)
  File
"/tmp/runkfMVYC/build/scripts/slave/.recipe_deps/depot_tools/subprocess2.py",
line 262, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory.
Check that /tmp/kitchen-995290350 or download_from_google_storage exist and have
execution permission.
step returned non-zero exit code: 1

[Paweł Hajdan Jr., 2016-02-05 11:45:12]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 11:45:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676473002/1

[commit-bot: I haz the power, 2016-02-05 11:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 11:47:13]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-02-05 11:56:41]

https://codereview.chromium.org/1676473002/diff/1/recipe_modules/gclient/api.py
File recipe_modules/gclient/api.py (right):

https://codereview.chromium.org/1676473002/diff/1/recipe_modules/gclient/api....
recipe_modules/gclient/api.py:94: kwargs['env'].setdefault('PATH', '%(PATH)s')
Is there a % operator applied on the value later?

https://codereview.chromium.org/1676473002/diff/1/recipe_modules/gclient/api....
recipe_modules/gclient/api.py:96: kwargs['env']['PATH'],
str(self._module.PACKAGE_DIRECTORY)])
Do you want it in the end? What if there is another (wrong) depot_tools in the
path? Maybe better append it at the beginning?

https://codereview.chromium.org/1676473002/diff/1/recipe_modules/gclient/exam...
File recipe_modules/gclient/example.expected/basic.json (right):

https://codereview.chromium.org/1676473002/diff/1/recipe_modules/gclient/exam...
recipe_modules/gclient/example.expected/basic.json:13: "PATH":
"%(PATH)s:RECIPE_PACKAGE[depot_tools]"
This %(PATH)s doesn't really look right.

[Michael Achenbach, 2016-02-05 11:59:44]

lgtm as it works in presubmit in a similar way.

[Paweł Hajdan Jr., 2016-02-05 12:00:21]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-02-05 12:00:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676473002/1

[commit-bot: I haz the power, 2016-02-05 12:02:22]

Description was changed from

==========
gclient: add depot_tools to PATH

BUG=437264
==========

to

==========
gclient: add depot_tools to PATH

BUG=437264

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298614
==========

[commit-bot: I haz the power, 2016-02-05 12:02:22]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298614