gclient: add depot_tools to PATH

recipe_modules/gclient/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 
 
 class RevisionResolver(object):
   """Resolves the revision based on build properties."""
 
@@ skipping 72 matching lines @@
     self.USE_MIRROR = None
     self._spec_alias = None
 
   def __call__(self, name, cmd, infra_step=True, **kwargs):
     """Wrapper for easy calling of gclient steps."""
     assert isinstance(cmd, (list, tuple))
     prefix = 'gclient '
     if self.spec_alias:
       prefix = ('[spec: %s] ' % self.spec_alias) + prefix
 
+    kwargs.setdefault('env', {})
+    kwargs['env'].setdefault('PATH', '%(PATH)s')

[Michael Achenbach, 2016/02/05 11:56:41]

Is there a % operator applied on the value later?

+    kwargs['env']['PATH'] = self.m.path.pathsep.join([
+        kwargs['env']['PATH'], str(self._module.PACKAGE_DIRECTORY)])

[Michael Achenbach, 2016/02/05 11:56:41]

Do you want it in the end? What if there is another (wrong) depot_tools in the
path? Maybe better append it at the beginning?

+
     return self.m.python(prefix + name,
                          self.package_resource('gclient.py'),
                          cmd,
                          infra_step=infra_step,
                          **kwargs)
 
   @property
   def use_mirror(self):
     """Indicates if gclient will use mirrors in its configuration."""
     if self.USE_MIRROR is None:
@@ skipping 214 matching lines @@
           for (path, dir, files) in os.walk(build_path):
             for cur_file in files:
               if cur_file.endswith('index.lock'):
                 path_to_file = os.path.join(path, cur_file)
                 print 'deleting %s' % path_to_file
                 os.remove(path_to_file)
       """,
       args=[self.m.path['slave_build']],
       infra_step=True,
     )