gclient: add depot_tools to PATH

recipe_modules/gclient/api.py

Index: recipe_modules/gclient/api.py
diff --git a/recipe_modules/gclient/api.py b/recipe_modules/gclient/api.py
index e93de366138a941ce0da79eb6048445781456fa2..1b705d5b35d28efa7ce15cc73361cdfda960e24e 100644
--- a/recipe_modules/gclient/api.py
+++ b/recipe_modules/gclient/api.py
@@ -90,6 +90,11 @@ class GclientApi(recipe_api.RecipeApi):
     if self.spec_alias:
       prefix = ('[spec: %s] ' % self.spec_alias) + prefix
 
+    kwargs.setdefault('env', {})
+    kwargs['env'].setdefault('PATH', '%(PATH)s')

[Michael Achenbach, 2016/02/05 11:56:41]

Is there a % operator applied on the value later?

+    kwargs['env']['PATH'] = self.m.path.pathsep.join([
+        kwargs['env']['PATH'], str(self._module.PACKAGE_DIRECTORY)])

[Michael Achenbach, 2016/02/05 11:56:41]

Do you want it in the end? What if there is another (wrong) depot_tools in the
path? Maybe better append it at the beginning?

+
     return self.m.python(prefix + name,
                          self.package_resource('gclient.py'),
                          cmd,