Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2040)

Unified Diff: chrome/browser/devtools/device/cast_device_provider_unittest.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/cast_device_provider_unittest.cc
diff --git a/chrome/browser/devtools/device/cast_device_provider_unittest.cc b/chrome/browser/devtools/device/cast_device_provider_unittest.cc
index e713b71b77cf283eb8823c569564ab9c20f0ab4b..936d7e56099ade7a4b6cfd16e94d4794771643e1 100644
--- a/chrome/browser/devtools/device/cast_device_provider_unittest.cc
+++ b/chrome/browser/devtools/device/cast_device_provider_unittest.cc
@@ -6,7 +6,6 @@
#include "chrome/browser/devtools/device/android_device_manager.h"
#include "net/base/host_port_pair.h"
-#include "net/base/ip_address.h"
#include "testing/gtest/include/gtest/gtest.h"
using local_discovery::ServiceDescription;
@@ -51,8 +50,7 @@ TEST(CastDeviceProviderTest, ServiceDiscovery) {
cast_service.metadata.push_back("id=0123456789abcdef0123456789abcdef");
cast_service.metadata.push_back("ve=00");
cast_service.metadata.push_back("md=" + cast_service_model);
- ASSERT_TRUE(
- net::IPAddress::FromIPLiteral("192.168.1.101", &cast_service.ip_address));
+ ASSERT_TRUE(cast_service.ip_address.AssignFromIPLiteral("192.168.1.101"));
device_provider_->OnDeviceChanged(true, cast_service);
@@ -86,8 +84,7 @@ TEST(CastDeviceProviderTest, ServiceDiscovery) {
other_service.metadata.push_back("id=0123456789abcdef0123456789abcdef");
other_service.metadata.push_back("ve=00");
other_service.metadata.push_back("md=" + other_service_model);
- ASSERT_TRUE(
- net::IPAddress::FromIPLiteral("10.64.1.101", &other_service.ip_address));
+ ASSERT_TRUE(other_service.ip_address.AssignFromIPLiteral("10.64.1.101"));
// Callback should not be run, since this service is not yet discovered.
device_provider_->QueryDeviceInfo(other_service.address.host(),

Powered by Google App Engine
This is Rietveld 408576698