components/resource_provider/resource_provider_app.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resource_provider/resource_provider_app.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/resource_provider/public/cpp/resource_loader.cc ('k') | components/resource_provider/resource_provider_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/resource_provider/resource_provider_app.h

diff --git a/components/resource_provider/resource_provider_app.h b/components/resource_provider/resource_provider_app.h

index 81b2750fd5d51f1cd1d632126d14b2cdfb3bb313..8831e6c4ca5d38f9a87a3eb13356a07a42b646f1 100644

--- a/components/resource_provider/resource_provider_app.h

+++ b/components/resource_provider/resource_provider_app.h

@@ -16,7 +16,7 @@

#include "mojo/shell/public/cpp/interface_factory.h"

namespace mojo {

-class ApplicationImpl;

+class Shell;

}

namespace resource_provider {

@@ -29,7 +29,8 @@ class ResourceProviderApp : public mojo::ApplicationDelegate,

private:

// ApplicationDelegate:

- void Initialize(mojo::ApplicationImpl* app) override;

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override;

bool AcceptConnection(

mojo::ApplicationConnection* connection) override;