Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: content/public/renderer/render_view_observer.cc

Issue 1674543004: Separate RenderView from RenderWidget, part 1: inheritance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderwidgettest
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/render_view_observer.cc
diff --git a/content/public/renderer/render_view_observer.cc b/content/public/renderer/render_view_observer.cc
index 8289da949e1311a2769928a660a532edc75c5b44..5e876cc1bff979fbb4fd2e8e70a5d00e81b00b02 100644
--- a/content/public/renderer/render_view_observer.cc
+++ b/content/public/renderer/render_view_observer.cc
@@ -6,27 +6,22 @@
#include "content/renderer/render_view_impl.h"
-using blink::WebFrame;
-
namespace content {
RenderViewObserver::RenderViewObserver(RenderView* render_view)
- : render_view_(render_view),
+ : render_view_(static_cast<RenderViewImpl*>(render_view)),
routing_id_(MSG_ROUTING_NONE) {
- // |render_view| can be NULL on unit testing or if Observe() is used.
- if (render_view) {
- RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view);
- routing_id_ = impl->routing_id();
+ // |render_view_| can be null on unit testing or if Observe() is used.
+ if (render_view_) {
+ routing_id_ = render_view_->GetRoutingID();
// TODO(jam): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE);
- impl->AddObserver(this);
+ render_view_->AddObserver(this);
}
}
RenderViewObserver::~RenderViewObserver() {
- if (render_view_) {
- RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
- impl->RemoveObserver(this);
- }
+ if (render_view_)
+ render_view_->RemoveObserver(this);
}
void RenderViewObserver::OnDestruct() {
@@ -50,21 +45,19 @@ RenderView* RenderViewObserver::render_view() const {
}
void RenderViewObserver::RenderViewGone() {
- render_view_ = NULL;
+ render_view_ = nullptr;
}
void RenderViewObserver::Observe(RenderView* render_view) {
- RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
- if (impl) {
- impl->RemoveObserver(this);
+ if (render_view_) {
+ render_view_->RemoveObserver(this);
routing_id_ = 0;
}
- render_view_ = render_view;
- impl = static_cast<RenderViewImpl*>(render_view_);
- if (impl) {
- routing_id_ = impl->routing_id();
- impl->AddObserver(this);
+ render_view_ = static_cast<RenderViewImpl*>(render_view);
+ if (render_view_) {
+ routing_id_ = render_view_->GetRoutingID();
+ render_view_->AddObserver(this);
}
}

Powered by Google App Engine
This is Rietveld 408576698