runtime/vm/class_finalizer.h - Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/class_finalizer.h

Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/class_finalizer.h

diff --git a/runtime/vm/class_finalizer.h b/runtime/vm/class_finalizer.h

index 92a79abedf1423f5b4a223118fa8ddeb6580dd25..e630df031d61a706655edcf79637314a0f0f82d3 100644

--- a/runtime/vm/class_finalizer.h

+++ b/runtime/vm/class_finalizer.h

@@ -151,7 +151,8 @@ class ClassFinalizer : public AllStatic {

const TypeArguments& arguments,

Error* bound_error);

static void ResolveUpperBounds(const Class& cls);

- static void FinalizeUpperBounds(const Class& cls);

+ static void FinalizeUpperBounds(const Class& cls,

+ FinalizationKind finalization);

static void ResolveSignature(const Class& cls, const Function& function);

static void FinalizeSignature(const Class& cls, const Function& function);

static void ResolveAndFinalizeMemberTypes(const Class& cls);

« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »