Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: runtime/vm/class_finalizer.h

Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_CLASS_FINALIZER_H_ 5 #ifndef VM_CLASS_FINALIZER_H_
6 #define VM_CLASS_FINALIZER_H_ 6 #define VM_CLASS_FINALIZER_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/growable_array.h" 9 #include "vm/growable_array.h"
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 PendingTypes* pending_types, 144 PendingTypes* pending_types,
145 TrailPtr trail); 145 TrailPtr trail);
146 static void CheckRecursiveType(const Class& cls, 146 static void CheckRecursiveType(const Class& cls,
147 const AbstractType& type, 147 const AbstractType& type,
148 PendingTypes* pending_types); 148 PendingTypes* pending_types);
149 static void CheckTypeBounds(const Class& cls, const AbstractType& type); 149 static void CheckTypeBounds(const Class& cls, const AbstractType& type);
150 static void CheckTypeArgumentBounds(const Class& cls, 150 static void CheckTypeArgumentBounds(const Class& cls,
151 const TypeArguments& arguments, 151 const TypeArguments& arguments,
152 Error* bound_error); 152 Error* bound_error);
153 static void ResolveUpperBounds(const Class& cls); 153 static void ResolveUpperBounds(const Class& cls);
154 static void FinalizeUpperBounds(const Class& cls); 154 static void FinalizeUpperBounds(const Class& cls,
155 FinalizationKind finalization);
155 static void ResolveSignature(const Class& cls, const Function& function); 156 static void ResolveSignature(const Class& cls, const Function& function);
156 static void FinalizeSignature(const Class& cls, const Function& function); 157 static void FinalizeSignature(const Class& cls, const Function& function);
157 static void ResolveAndFinalizeMemberTypes(const Class& cls); 158 static void ResolveAndFinalizeMemberTypes(const Class& cls);
158 static void PrintClassInformation(const Class& cls); 159 static void PrintClassInformation(const Class& cls);
159 static void CollectInterfaces( 160 static void CollectInterfaces(
160 const Class& cls, GrowableArray<const Class*>* collected); 161 const Class& cls, GrowableArray<const Class*>* collected);
161 162
162 static void MarkTypeMalformed(const Error& prev_error, 163 static void MarkTypeMalformed(const Error& prev_error,
163 const Script& script, 164 const Script& script,
164 const Type& type, 165 const Type& type,
165 const char* format, 166 const char* format,
166 va_list args); 167 va_list args);
167 static void ReportError(const Error& error); 168 static void ReportError(const Error& error);
168 static void ReportError(const Class& cls, 169 static void ReportError(const Class& cls,
169 TokenPosition token_pos, 170 TokenPosition token_pos,
170 const char* format, ...) PRINTF_ATTRIBUTE(3, 4); 171 const char* format, ...) PRINTF_ATTRIBUTE(3, 4);
171 static void ReportErrors(const Error& prev_error, 172 static void ReportErrors(const Error& prev_error,
172 const Class& cls, 173 const Class& cls,
173 TokenPosition token_pos, 174 TokenPosition token_pos,
174 const char* format, ...) PRINTF_ATTRIBUTE(4, 5); 175 const char* format, ...) PRINTF_ATTRIBUTE(4, 5);
175 176
176 // Verify implicit offsets recorded in the VM for direct access to fields of 177 // Verify implicit offsets recorded in the VM for direct access to fields of
177 // Dart instances (e.g: _TypedListView, _ByteDataView). 178 // Dart instances (e.g: _TypedListView, _ByteDataView).
178 static void VerifyImplicitFieldOffsets(); 179 static void VerifyImplicitFieldOffsets();
179 }; 180 };
180 181
181 } // namespace dart 182 } // namespace dart
182 183
183 #endif // VM_CLASS_FINALIZER_H_ 184 #endif // VM_CLASS_FINALIZER_H_
OLDNEW
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698