Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: runtime/lib/mirrors.cc

Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 24254dbeb663aacdf1df30b14364b1d46aa5f7fb..b7d95b1c4a3f42ef2b72313d359c99504b26a495 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -783,7 +783,7 @@ static RawAbstractType* InstantiateType(const AbstractType& type,
TypeArguments::Handle(instantiator.arguments());
Error& bound_error = Error::Handle();
AbstractType& result = AbstractType::Handle(
- type.InstantiateFrom(type_args, &bound_error, NULL, Heap::kOld));
+ type.InstantiateFrom(type_args, &bound_error, NULL, NULL, Heap::kOld));
if (!bound_error.IsNull()) {
Exceptions::PropagateError(bound_error);
UNREACHABLE();
@@ -1675,7 +1675,7 @@ DEFINE_NATIVE_ENTRY(ClassMirror_invokeConstructor, 5) {
// type arguments of the type reflected by the class mirror.
Error& bound_error = Error::Handle();
redirect_type ^= redirect_type.InstantiateFrom(
- type_arguments, &bound_error, NULL, Heap::kOld);
+ type_arguments, &bound_error, NULL, NULL, Heap::kOld);
if (!bound_error.IsNull()) {
Exceptions::PropagateError(bound_error);
UNREACHABLE();
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698