Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: tracing/tracing/ui/extras/about_tracing/profiling_view_test.html

Issue 1673893002: [trace-viewer] Removed monitoring mode (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/about_tracing/profiling_view_test.html
diff --git a/tracing/tracing/ui/extras/about_tracing/profiling_view_test.html b/tracing/tracing/ui/extras/about_tracing/profiling_view_test.html
index 76b4cc613beaca47d21847d305025355e924da18..457d074fe240a3c6a7356d990c47d203cc9bbad3 100644
--- a/tracing/tracing/ui/extras/about_tracing/profiling_view_test.html
+++ b/tracing/tracing/ui/extras/about_tracing/profiling_view_test.html
@@ -37,9 +37,6 @@ tr.b.unittest.testSuite(function() {
test('recording', function() {
var mock = new tr.ui.e.about_tracing.MockTracingControllerClient();
mock.allowLooping = true;
- mock.expectRequest('getMonitoringStatus', function() {
- return Base64.btoa(JSON.stringify(monitoringOptions));
- });
mock.expectRequest('endRecording', function() {
return '';
});
@@ -82,58 +79,6 @@ tr.b.unittest.testSuite(function() {
});
});
});
-
- test('monitoring', function() {
- var mock = new tr.ui.e.about_tracing.MockTracingControllerClient();
- mock.allowLooping = true;
- mock.expectRequest('getMonitoringStatus', function() {
- return Base64.btoa(JSON.stringify(monitoringOptions));
- });
- mock.expectRequest('beginMonitoring', function(data) {
- return '';
- });
- mock.expectRequest('captureMonitoring', function(data) {
- return JSON.stringify(testData);
- });
- mock.expectRequest('endMonitoring', function(data) {
- return '';
- });
-
- var view = new ProfilingView(mock);
- view.style.height = '400px';
- view.style.border = '1px solid black';
- this.addHTMLOutput(view);
-
- return new Promise(function(resolve, reject) {
- assert.isFalse(view.monitorCheckbox_.checked);
-
- function beginMonitoring() {
- // Since we don't fall back to TracingController when testing,
- // we cannot rely on TracingController to invoke a callback to change
- // view.isMonitoring_. Thus we change view.isMonitoring_ manually.
- view.onMonitoringStateChanged_(true);
- assert.isTrue(view.monitorCheckbox_.checked);
- setTimeout(captureMonitoring, 60);
- }
-
- function captureMonitoring() {
- assert.isTrue(view.monitorCheckbox_.checked);
- view.captureButton_.click();
- setTimeout(endMonitoring, 60);
- }
-
- function endMonitoring() {
- assert.isTrue(view.monitorCheckbox_.checked);
- view.monitorCheckbox_.click();
- assert.isFalse(view.monitorCheckbox_.checked);
- }
-
- var monitoringPromise = view.beginMonitoring();
- setTimeout(beginMonitoring, 60);
-
- monitoringPromise.then(resolve, reject);
- });
- });
});
</script>

Powered by Google App Engine
This is Rietveld 408576698