Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tracing/tracing/ui/extras/about_tracing/record_controller.html

Issue 1673893002: [trace-viewer] Removed monitoring mode (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/about_tracing/record_controller.html
diff --git a/tracing/tracing/ui/extras/about_tracing/record_and_capture_controller.html b/tracing/tracing/ui/extras/about_tracing/record_controller.html
similarity index 78%
rename from tracing/tracing/ui/extras/about_tracing/record_and_capture_controller.html
rename to tracing/tracing/ui/extras/about_tracing/record_controller.html
index ad1a5b1382c64d08678a8e13f3c3d770e4afc95e..2284b0fa3e7dd250a9b57d36bd72cba9e9d32129 100644
--- a/tracing/tracing/ui/extras/about_tracing/record_and_capture_controller.html
+++ b/tracing/tracing/ui/extras/about_tracing/record_controller.html
@@ -11,59 +11,6 @@ found in the LICENSE file.
'use strict';
tr.exportTo('tr.ui.e.about_tracing', function() {
- function beginMonitoring(tracingControllerClient) {
- var finalPromiseResolver;
- var finalPromise = new Promise(function(resolve, reject) {
- finalPromiseResolver = {
- resolve: resolve,
- reject: reject
- };
- });
-
- // TODO(haraken): Implement a configure dialog to set these options.
- var monitoringOptions = {
- categoryFilter: '*',
- useSystemTracing: false,
- tracingRecordMode: 'record-until-full',
- useSampling: true
- };
-
-
- var beginMonitoringPromise = tracingControllerClient.beginMonitoring(
- monitoringOptions);
-
- beginMonitoringPromise.then(
- function() {
- finalPromiseResolver.resolve();
- },
- function(err) {
- finalPromiseResolver.reject(err);
- });
-
- return finalPromise;
- }
-
- function endMonitoring(tracingControllerClient) {
- var endMonitoringPromise = tracingControllerClient.endMonitoring();
- return endMonitoringPromise.then(
- function() {
- },
- function(err) {
- });
- }
-
- function captureMonitoring(tracingControllerClient) {
- var captureMonitoringPromise =
- tracingControllerClient.captureMonitoring();
- return captureMonitoringPromise;
- }
-
- function getMonitoringStatus(tracingControllerClient) {
- var getMonitoringStatusPromise =
- tracingControllerClient.getMonitoringStatus();
- return getMonitoringStatusPromise;
- }
-
function beginRecording(tracingControllerClient) {
var finalPromiseResolver;
var finalPromise = new Promise(function(resolve, reject) {
@@ -89,7 +36,7 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
// But just in case, bind onbeforeunload anyway.
window.onbeforeunload = function(e) {
endRecording(tracingControllerClient);
- }
+ };
// Step 1: Get categories.
function getCategories() {
@@ -227,10 +174,6 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
return {
beginRecording: beginRecording,
- beginMonitoring: beginMonitoring,
- endMonitoring: endMonitoring,
- captureMonitoring: captureMonitoring,
- getMonitoringStatus: getMonitoringStatus,
UserCancelledError: UserCancelledError,
defaultTraceName: defaultTraceName
};

Powered by Google App Engine
This is Rietveld 408576698