Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: src/interpreter/interpreter.h

Issue 1673333004: [Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/DEPS ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.h
diff --git a/src/interpreter/interpreter.h b/src/interpreter/interpreter.h
index 1a3143b02d8f5af69af1497e855932a63eb76885..b235f0ae0f9541a22ef575e00336cad23dc38436 100644
--- a/src/interpreter/interpreter.h
+++ b/src/interpreter/interpreter.h
@@ -21,12 +21,10 @@ class Isolate;
class Callable;
class CompilationInfo;
-namespace compiler {
-class InterpreterAssembler;
-}
-
namespace interpreter {
+class InterpreterAssembler;
+
class Interpreter {
public:
explicit Interpreter(Isolate* isolate);
@@ -41,6 +39,8 @@ class Interpreter {
// GC support.
void IterateDispatchTable(ObjectVisitor* v);
+ void TraceCodegen(Handle<Code> code, const char* name);
+
Address dispatch_table_address() {
return reinterpret_cast<Address>(&dispatch_table_[0]);
}
@@ -48,74 +48,73 @@ class Interpreter {
private:
// Bytecode handler generator functions.
#define DECLARE_BYTECODE_HANDLER_GENERATOR(Name, ...) \
- void Do##Name(compiler::InterpreterAssembler* assembler);
+ void Do##Name(InterpreterAssembler* assembler);
BYTECODE_LIST(DECLARE_BYTECODE_HANDLER_GENERATOR)
#undef DECLARE_BYTECODE_HANDLER_GENERATOR
// Generates code to perform the binary operations via |function_id|.
void DoBinaryOp(Runtime::FunctionId function_id,
- compiler::InterpreterAssembler* assembler);
+ InterpreterAssembler* assembler);
// Generates code to perform the count operations via |function_id|.
void DoCountOp(Runtime::FunctionId function_id,
- compiler::InterpreterAssembler* assembler);
+ InterpreterAssembler* assembler);
// Generates code to perform the comparison operation associated with
// |compare_op|.
- void DoCompareOp(Token::Value compare_op,
- compiler::InterpreterAssembler* assembler);
+ void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler);
// Generates code to load a constant from the constant pool.
- void DoLoadConstant(compiler::InterpreterAssembler* assembler);
+ void DoLoadConstant(InterpreterAssembler* assembler);
// Generates code to perform a global load via |ic|.
- void DoLoadGlobal(Callable ic, compiler::InterpreterAssembler* assembler);
+ void DoLoadGlobal(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a global store via |ic|.
- void DoStoreGlobal(Callable ic, compiler::InterpreterAssembler* assembler);
+ void DoStoreGlobal(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a named property load via |ic|.
- void DoLoadIC(Callable ic, compiler::InterpreterAssembler* assembler);
+ void DoLoadIC(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a keyed property load via |ic|.
- void DoKeyedLoadIC(Callable ic, compiler::InterpreterAssembler* assembler);
+ void DoKeyedLoadIC(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a namedproperty store via |ic|.
- void DoStoreIC(Callable ic, compiler::InterpreterAssembler* assembler);
+ void DoStoreIC(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a keyed property store via |ic|.
- void DoKeyedStoreIC(Callable ic, compiler::InterpreterAssembler* assembler);
+ void DoKeyedStoreIC(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a JS call.
- void DoJSCall(compiler::InterpreterAssembler* assembler);
+ void DoJSCall(InterpreterAssembler* assembler);
// Generates code to perform a runtime call.
- void DoCallRuntimeCommon(compiler::InterpreterAssembler* assembler);
+ void DoCallRuntimeCommon(InterpreterAssembler* assembler);
// Generates code to perform a runtime call returning a pair.
- void DoCallRuntimeForPairCommon(compiler::InterpreterAssembler* assembler);
+ void DoCallRuntimeForPairCommon(InterpreterAssembler* assembler);
// Generates code to perform a JS runtime call.
- void DoCallJSRuntimeCommon(compiler::InterpreterAssembler* assembler);
+ void DoCallJSRuntimeCommon(InterpreterAssembler* assembler);
// Generates code to perform a constructor call..
- void DoCallConstruct(compiler::InterpreterAssembler* assembler);
+ void DoCallConstruct(InterpreterAssembler* assembler);
// Generates code ro create a literal via |function_id|.
void DoCreateLiteral(Runtime::FunctionId function_id,
- compiler::InterpreterAssembler* assembler);
+ InterpreterAssembler* assembler);
// Generates code to perform delete via function_id.
void DoDelete(Runtime::FunctionId function_id,
- compiler::InterpreterAssembler* assembler);
+ InterpreterAssembler* assembler);
// Generates code to perform a lookup slot load via |function_id|.
void DoLoadLookupSlot(Runtime::FunctionId function_id,
- compiler::InterpreterAssembler* assembler);
+ InterpreterAssembler* assembler);
// Generates code to perform a lookup slot store depending on |language_mode|.
void DoStoreLookupSlot(LanguageMode language_mode,
- compiler::InterpreterAssembler* assembler);
+ InterpreterAssembler* assembler);
bool IsDispatchTableInitialized();
« no previous file with comments | « src/interpreter/DEPS ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698