blink::TransformationMatrix implement create methods

third_party/WebKit/Source/platform/transforms/TransformationMatrix.h

 /*
  * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 15 matching lines @@
 #ifndef TransformationMatrix_h
 #define TransformationMatrix_h
 
 #include "SkMatrix44.h"
 #include "platform/geometry/FloatPoint.h"
 #include "platform/geometry/FloatPoint3D.h"
 #include "platform/geometry/IntPoint.h"
 #include "wtf/Alignment.h"
 #include "wtf/Allocator.h"
 #include "wtf/CPU.h"
+#include "wtf/PassOwnPtr.h"
 #include <string.h> // for memcpy
 
 namespace blink {
 
 class AffineTransform;
 class IntRect;
 class LayoutRect;
 class FloatRect;
 class FloatQuad;
 class FloatBox;
 #if CPU(X86_64)
 #define TRANSFORMATION_MATRIX_USE_X86_64_SSE2
 #endif
 
 // TransformationMatrix must not be allocated on Oilpan's heap since
 // Oilpan doesn't (yet) have an ability to allocate the TransformationMatrix
 // with 16-byte alignment. PartitionAlloc has the ability.
 class PLATFORM_EXPORT TransformationMatrix {
     USING_FAST_MALLOC(TransformationMatrix);
 public:
 
 #if defined(TRANSFORMATION_MATRIX_USE_X86_64_SSE2)
     typedef WTF_ALIGNED(double, Matrix4[4][4], 16);
 #else
     typedef double Matrix4[4][4];
 #endif
 
+    static PassOwnPtr<TransformationMatrix> create()
+    {
+        return adoptPtr(new TransformationMatrix());
+    }
+    static PassOwnPtr<TransformationMatrix> create(const AffineTransform& t)
+    {
+        return adoptPtr(new TransformationMatrix(t));
+    }
+    static PassOwnPtr<TransformationMatrix> create(const TransformationMatrix& t)
+    {
+        return adoptPtr(new TransformationMatrix(t));
+    }
+    static PassOwnPtr<TransformationMatrix> create(double a, double b, double c, double d, double e, double f)
+    {
+        return adoptPtr(new TransformationMatrix(a, b, c, d, e, f));
+    }
+    static PassOwnPtr<TransformationMatrix> create(double m11, double m12, double m13, double m14,
+        double m21, double m22, double m23, double m24,
+        double m31, double m32, double m33, double m34,
+        double m41, double m42, double m43, double m44)
+    {
+        return adoptPtr(new TransformationMatrix(m11, m12, m13, m14, m21, m22, m23, m24, m31, m32, m33, m34, m41, m42, m43, m44));
+    }

[alancutter (OOO until 2018), 2016/02/08 04:29:52]

Are all these needed? Can we omit any that aren't being used?

[tridgell, 2016/02/08 05:30:54]

Done.  Removed.  The only unused one was create(const AffineTransform&).

+
     TransformationMatrix()
     {
         checkAlignment();
         makeIdentity();
     }
     TransformationMatrix(const AffineTransform&);
     TransformationMatrix(const TransformationMatrix& t)
     {
         checkAlignment();
         *this = t;
@@ skipping 325 matching lines @@
     Matrix4 m_matrix;
 };
 
 // Redeclared here to avoid ODR issues.
 // See platform/testing/TransformPrinters.h.
 void PrintTo(const TransformationMatrix&, std::ostream*);
 
 } // namespace blink
 
 #endif // TransformationMatrix_h