third_party/WebKit/Source/platform/geometry/TransformState.cpp - Issue 1673093003: blink::TransformationMatrix implement create methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/TransformState.cpp

Issue 1673093003: blink::TransformationMatrix implement create methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove TransfromationMatrix::create(const AffineTransform&) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/platform/transforms/TransformationMatrix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/TransformState.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/TransformState.cpp b/third_party/WebKit/Source/platform/geometry/TransformState.cpp

index 918a73c07b207ae172b00815b0f6c8b512113271..d50b16d2fd5a7b5bf8219c20a52d5ab59dcd9335 100644

--- a/third_party/WebKit/Source/platform/geometry/TransformState.cpp

+++ b/third_party/WebKit/Source/platform/geometry/TransformState.cpp

@@ -44,7 +44,7 @@ TransformState& TransformState::operator=(const TransformState& other)

m_accumulatedTransform.clear();

if (other.m_accumulatedTransform)

- m_accumulatedTransform = adoptPtr(new TransformationMatrix(*other.m_accumulatedTransform));

+ m_accumulatedTransform = TransformationMatrix::create(*other.m_accumulatedTransform);

return *this;

}

@@ -118,12 +118,12 @@ void TransformState::applyTransform(const TransformationMatrix& transformFromCon

// If we have an accumulated transform from last time, multiply in this transform

if (m_accumulatedTransform) {

if (m_direction == ApplyTransformDirection)

- m_accumulatedTransform = adoptPtr(new TransformationMatrix(transformFromContainer * *m_accumulatedTransform));

+ m_accumulatedTransform = TransformationMatrix::create(transformFromContainer * *m_accumulatedTransform);

else

m_accumulatedTransform->multiply(transformFromContainer);

} else if (accumulate == AccumulateTransform) {

// Make one if we started to accumulate

- m_accumulatedTransform = adoptPtr(new TransformationMatrix(transformFromContainer));

+ m_accumulatedTransform = TransformationMatrix::create(transformFromContainer);

}

if (accumulate == FlattenTransform) {