Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: server/logdog/storage/bigtable/storage_test.go

Issue 1672833003: LogDog: Add log rendering view. Base URL: https://github.com/luci/luci-go@master
Patch Set: Clean up, add tests, little reorg. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/logdog/storage/bigtable/bigtable.go ('k') | server/logdog/storage/memory/memory.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/logdog/storage/bigtable/storage_test.go
diff --git a/server/logdog/storage/bigtable/storage_test.go b/server/logdog/storage/bigtable/storage_test.go
index 0753455e83f91bb5b4ae6f60f0561b0cb92a5c22..8bf3ebf172909a5adf6d63597f0b63030da15ad0 100644
--- a/server/logdog/storage/bigtable/storage_test.go
+++ b/server/logdog/storage/bigtable/storage_test.go
@@ -73,7 +73,7 @@ func (t *btTableTest) putLogData(c context.Context, rk *rowKey, d []byte) error
return nil
}
-func (t *btTableTest) getLogData(c context.Context, rk *rowKey, limit int, keysOnly bool, cb btGetCallback) error {
+func (t *btTableTest) getLogData(c context.Context, rk *rowKey, limit int64, keysOnly bool, cb btGetCallback) error {
if t.err != nil {
return t.err
}
@@ -166,7 +166,7 @@ func TestStorage(t *testing.T) {
table: &bt,
}
- get := func(path string, index int, limit int) ([]string, error) {
+ get := func(path string, index int, limit int64) ([]string, error) {
req := storage.GetRequest{
Path: types.StreamPath(path),
Index: types.MessageIndex(index),
« no previous file with comments | « server/logdog/storage/bigtable/bigtable.go ('k') | server/logdog/storage/memory/memory.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698