Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: server/logdog/storage/bigtable/bigtable.go

Issue 1672833003: LogDog: Add log rendering view. Base URL: https://github.com/luci/luci-go@master
Patch Set: Clean up, add tests, little reorg. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/logdog/storage/archive/storage.go ('k') | server/logdog/storage/bigtable/storage_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/logdog/storage/bigtable/bigtable.go
diff --git a/server/logdog/storage/bigtable/bigtable.go b/server/logdog/storage/bigtable/bigtable.go
index 56ab8b71f1ec8d34983480104fcc974bfe60488e..ff2e525acc2ae03c3bb185d70fa394623c1a6be2 100644
--- a/server/logdog/storage/bigtable/bigtable.go
+++ b/server/logdog/storage/bigtable/bigtable.go
@@ -46,7 +46,7 @@ type btTable interface {
// retrieved.
//
// If keysOnly is true, then the callback will return nil row data.
- getLogData(c context.Context, rk *rowKey, limit int, keysOnly bool, cb btGetCallback) error
+ getLogData(c context.Context, rk *rowKey, limit int64, keysOnly bool, cb btGetCallback) error
// deleteRow deletes the log data associated with a given row.
deleteRow(context.Context, *rowKey) error
@@ -74,7 +74,7 @@ func (t *btTableProd) putLogData(c context.Context, rk *rowKey, data []byte) err
return nil
}
-func (t *btTableProd) getLogData(c context.Context, rk *rowKey, limit int, keysOnly bool, cb btGetCallback) error {
+func (t *btTableProd) getLogData(c context.Context, rk *rowKey, limit int64, keysOnly bool, cb btGetCallback) error {
// Construct read options based on Get request.
ropts := []bigtable.ReadOption{
bigtable.RowFilter(bigtable.FamilyFilter("log")),
@@ -86,7 +86,7 @@ func (t *btTableProd) getLogData(c context.Context, rk *rowKey, limit int, keysO
ropts = append(ropts, bigtable.RowFilter(bigtable.StripValueFilter()))
}
if limit > 0 {
- ropts = append(ropts, bigtable.LimitRows(int64(limit)))
+ ropts = append(ropts, bigtable.LimitRows(limit))
}
// This will limit the range to the immediate row key ("ASDF~INDEX") to
« no previous file with comments | « server/logdog/storage/archive/storage.go ('k') | server/logdog/storage/bigtable/storage_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698