Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: server/logdog/storage/memory/memory.go

Issue 1672833003: LogDog: Add log rendering view. Base URL: https://github.com/luci/luci-go@master
Patch Set: Clean up, add tests, little reorg. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/logdog/storage/bigtable/storage_test.go ('k') | server/logdog/storage/storage.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/logdog/storage/memory/memory.go
diff --git a/server/logdog/storage/memory/memory.go b/server/logdog/storage/memory/memory.go
index 26bde86c08add991966109f0efdd1ae64694ed5a..524fb28a92593db98d49708823204c3ce136c635 100644
--- a/server/logdog/storage/memory/memory.go
+++ b/server/logdog/storage/memory/memory.go
@@ -29,7 +29,7 @@ type rec struct {
type Storage struct {
// MaxGetCount, if not zero, is the maximum number of records to retrieve from
// a single Get request.
- MaxGetCount int
+ MaxGetCount int64
stateMu sync.Mutex
streams map[types.StreamPath]*logStream
@@ -72,7 +72,7 @@ func (s *Storage) Get(req *storage.GetRequest, cb storage.GetCallback) error {
return storage.ErrDoesNotExist
}
- limit := len(ls.logs)
+ limit := int64(len(ls.logs))
if req.Limit > 0 && req.Limit < limit {
limit = req.Limit
}
@@ -89,7 +89,7 @@ func (s *Storage) Get(req *storage.GetRequest, cb storage.GetCallback) error {
})
}
- if len(recs) >= limit {
+ if int64(len(recs)) >= limit {
break
}
}
« no previous file with comments | « server/logdog/storage/bigtable/storage_test.go ('k') | server/logdog/storage/storage.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698