LogDog: Add log rendering view.

LogDog: Add log rendering view.

Add an HTTP handler to view a log stream.

Also normalize count constraints to int64 (instead of sometimes int) to
avoid the need to impose integer safety checks everywhere.

BUG=

[dnj, 2016-02-08 17:35:35]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org, iannucci@chromium.org

[dnj, 2016-02-08 17:35:35]

PTAL

[Ryan Tseng, 2016-02-08 22:56:54]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2016-02-08 22:56:55]

lgtm

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
File appengine/logdog/coordinator/logView/view.go (right):

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
2016  /happy new year

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:115: fetchCtx, cancelFunc :=
context.WithCancel(c)
cancelFunc isn't used anywhere

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:151: func (f *storageLogSource)
LogEntries(c context.Context, req *fetcher.LogRequest) (
docstring (lint should catch this)

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:186: // Issue the Get request.
presumably for all chunks of a logstream?

https://codereview.chromium.org/1672833003/diff/1/client/cmd/logdog_cat/coord...
File client/cmd/logdog_cat/coordinatorSource.go (right):

https://codereview.chromium.org/1672833003/diff/1/client/cmd/logdog_cat/coord...
client/cmd/logdog_cat/coordinatorSource.go:50: }
log warning?

[dnj (Google), 2016-02-09 02:50:03]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2016-02-09 02:50:03]

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
File appengine/logdog/coordinator/logView/view.go (right):

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/02/08 22:56:55, Ryan Tseng wrote:
> 2016  /happy new year

Done.

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:115: fetchCtx, cancelFunc :=
context.WithCancel(c)
On 2016/02/08 22:56:55, Ryan Tseng wrote:
> cancelFunc isn't used anywhere

Done.

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:151: func (f *storageLogSource)
LogEntries(c context.Context, req *fetcher.LogRequest) (
On 2016/02/08 22:56:55, Ryan Tseng wrote:
> docstring (lint should catch this)

It's a public method on a private struct, so that's not necessary. In this case,
it's implementing an interface, so the interface's documentation should be
sufficient. No need to repeat.

https://codereview.chromium.org/1672833003/diff/1/appengine/logdog/coordinato...
appengine/logdog/coordinator/logView/view.go:186: // Issue the Get request.
On 2016/02/08 22:56:55, Ryan Tseng wrote:
> presumably for all chunks of a logstream?

Well, for the ones requested via "req".

https://codereview.chromium.org/1672833003/diff/1/client/cmd/logdog_cat/coord...
File client/cmd/logdog_cat/coordinatorSource.go (right):

https://codereview.chromium.org/1672833003/diff/1/client/cmd/logdog_cat/coord...
client/cmd/logdog_cat/coordinatorSource.go:50: }
On 2016/02/08 22:56:55, Ryan Tseng wrote:
> log warning?

No need. The "bytes" and "count" parameters are permitted to be internally
reduced as an implementation detail. The supplied parameters are just maximums.