Pass the frame instead of the WebContents through RunBluetoothChooser.

Pass the frame instead of the WebContents through RunBluetoothChooser.

This lets us auto-close the bubble when the right frame is closed, in case the
chooser is attached to a non-main frame.

BUG=571466
Committed: https://crrev.com/93649a5d93a0219d92f4a99d3486f7704aec605e
Cr-Commit-Position: refs/heads/master@{#375959}

[Jeffrey Yasskin, 2016-02-17 01:36:32]

Patchset #1 (id:1) has been deleted

[Jeffrey Yasskin, 2016-02-17 01:36:37]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 01:39:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672103002/20001

[Jeffrey Yasskin, 2016-02-17 01:43:24]

jyasskin@chromium.org changed reviewers:
+ jam@chromium.org, pkasting@chromium.org

[Jeffrey Yasskin, 2016-02-17 01:43:25]

This continues https://codereview.chromium.org/1572743002 by passing the
RenderFrameHost that opened the Bluetooth chooser, instead of its parent
WebContents, through the content API. If that frame is destroyed before its tab
is, the dialog could have stayed open inappropriately (except for the redundant
code that https://crbug.com/571466 is trying to get rid of).

[jam, 2016-02-17 01:54:16]

lgtm with comment if you agree

https://codereview.chromium.org/1672103002/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1672103002/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:1079:
render_frame_host->GetLastCommittedOrigin());
no need to give this last parameter since the caller can call the method
themselves?

[Peter Kasting, 2016-02-17 02:51:58]

LGTM

[commit-bot: I haz the power, 2016-02-17 04:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 04:05:56]

Dry run: This issue passed the CQ dry run.

[Jeffrey Yasskin, 2016-02-17 17:51:36]

https://codereview.chromium.org/1672103002/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1672103002/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:1079:
render_frame_host->GetLastCommittedOrigin());
On 2016/02/17 01:54:16, jam wrote:
> no need to give this last parameter since the caller can call the method
> themselves?

Oops, you're totally right. I've removed it. Thanks!

[Jeffrey Yasskin, 2016-02-17 17:51:40]

The CQ bit was checked by jyasskin@chromium.org

[Jeffrey Yasskin, 2016-02-17 17:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1672103002/#ps40001
(title: "Don't pass the origin through RunBluetoothChooser, since it's
computable from the RenderFrameHost.")

[commit-bot: I haz the power, 2016-02-17 17:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672103002/40001

[commit-bot: I haz the power, 2016-02-17 18:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 18:11:43]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Jeffrey Yasskin, 2016-02-17 18:19:34]

The CQ bit was checked by jyasskin@chromium.org

[Jeffrey Yasskin, 2016-02-17 18:19:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1672103002/#ps60001
(title: "Fix Android")

[commit-bot: I haz the power, 2016-02-17 18:20:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672103002/60001

[commit-bot: I haz the power, 2016-02-17 19:57:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-02-17 19:58:42]

Description was changed from

==========
Pass the frame instead of the WebContents through RunBluetoothChooser.

This lets us auto-close the bubble when the right frame is closed, in case the
chooser is attached to a non-main frame.

BUG=571466
==========

to

==========
Pass the frame instead of the WebContents through RunBluetoothChooser.

This lets us auto-close the bubble when the right frame is closed, in case the
chooser is attached to a non-main frame.

BUG=571466

Committed: https://crrev.com/93649a5d93a0219d92f4a99d3486f7704aec605e
Cr-Commit-Position: refs/heads/master@{#375959}
==========

[commit-bot: I haz the power, 2016-02-17 19:58:43]

Patchset 3 (id:??) landed as
https://crrev.com/93649a5d93a0219d92f4a99d3486f7704aec605e
Cr-Commit-Position: refs/heads/master@{#375959}