chrome/browser/android/tab_web_contents_delegate_android.cc - Issue 1672103002: Pass the frame instead of the WebContents through RunBluetoothChooser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.cc

Issue 1672103002: Pass the frame instead of the WebContents through RunBluetoothChooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doc-bubble-lifetimes

Patch Set: Fix Android Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/tab_web_contents_delegate_android.h ('k') | chrome/browser/ui/android/bluetooth_chooser_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/tab_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc

index 9a5d845293ef8aef6f2504449c57974789f15771..2298726ef3133f91d15673df9a32e760a9af52a0 100644

--- a/chrome/browser/android/tab_web_contents_delegate_android.cc

+++ b/chrome/browser/android/tab_web_contents_delegate_android.cc

@@ -123,11 +123,9 @@ void TabWebContentsDelegateAndroid::RunFileChooser(

}

scoped_ptr<BluetoothChooser> TabWebContentsDelegateAndroid::RunBluetoothChooser(

- content::WebContents* web_contents,

- const BluetoothChooser::EventHandler& event_handler,

- const url::Origin& origin) {

- return make_scoped_ptr(

- new BluetoothChooserAndroid(web_contents, event_handler, origin));

+ content::RenderFrameHost* frame,

+ const BluetoothChooser::EventHandler& event_handler) {

+ return make_scoped_ptr(new BluetoothChooserAndroid(frame, event_handler));

}

void TabWebContentsDelegateAndroid::CloseContents(