Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 1672103002: Pass the frame instead of the WebContents through RunBluetoothChooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doc-bubble-lifetimes
Patch Set: Fix Android Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | content/browser/bluetooth/bluetooth_dispatcher_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <string> 10 #include <string>
(...skipping 1397 matching lines...) Expand 10 before | Expand all | Expand 10 after
1408 1408
1409 void Browser::ShowCertificateViewerInDevTools( 1409 void Browser::ShowCertificateViewerInDevTools(
1410 content::WebContents* web_contents, int cert_id) { 1410 content::WebContents* web_contents, int cert_id) {
1411 DevToolsWindow* devtools_window = 1411 DevToolsWindow* devtools_window =
1412 DevToolsWindow::GetInstanceForInspectedWebContents(web_contents); 1412 DevToolsWindow::GetInstanceForInspectedWebContents(web_contents);
1413 if (devtools_window) 1413 if (devtools_window)
1414 devtools_window->ShowCertificateViewer(cert_id); 1414 devtools_window->ShowCertificateViewer(cert_id);
1415 } 1415 }
1416 1416
1417 scoped_ptr<content::BluetoothChooser> Browser::RunBluetoothChooser( 1417 scoped_ptr<content::BluetoothChooser> Browser::RunBluetoothChooser(
1418 content::WebContents* web_contents, 1418 content::RenderFrameHost* frame,
1419 const content::BluetoothChooser::EventHandler& event_handler, 1419 const content::BluetoothChooser::EventHandler& event_handler) {
1420 const url::Origin& origin) {
1421 scoped_ptr<BluetoothChooserDesktop> bluetooth_chooser_desktop( 1420 scoped_ptr<BluetoothChooserDesktop> bluetooth_chooser_desktop(
1422 new BluetoothChooserDesktop(event_handler)); 1421 new BluetoothChooserDesktop(event_handler));
1423 scoped_ptr<BluetoothChooserBubbleDelegate> bubble_delegate( 1422 scoped_ptr<BluetoothChooserBubbleDelegate> bubble_delegate(
1424 new BluetoothChooserBubbleDelegate(web_contents->GetMainFrame())); 1423 new BluetoothChooserBubbleDelegate(frame));
1425 BluetoothChooserBubbleDelegate* bubble_delegate_ptr = bubble_delegate.get(); 1424 BluetoothChooserBubbleDelegate* bubble_delegate_ptr = bubble_delegate.get();
1426 1425
1427 // Wire the ChooserBubbleDelegate to the BluetoothChooser. 1426 // Wire the ChooserBubbleDelegate to the BluetoothChooser.
1428 bluetooth_chooser_desktop->set_bluetooth_chooser_bubble_delegate( 1427 bluetooth_chooser_desktop->set_bluetooth_chooser_bubble_delegate(
1429 bubble_delegate_ptr); 1428 bubble_delegate_ptr);
1430 bubble_delegate->set_bluetooth_chooser(bluetooth_chooser_desktop.get()); 1429 bubble_delegate->set_bluetooth_chooser(bluetooth_chooser_desktop.get());
1431 1430
1432 Browser* browser = chrome::FindBrowserWithWebContents(web_contents); 1431 Browser* browser = chrome::FindBrowserWithWebContents(
1432 WebContents::FromRenderFrameHost(frame));
1433 BubbleReference bubble_controller = 1433 BubbleReference bubble_controller =
1434 browser->GetBubbleManager()->ShowBubble(std::move(bubble_delegate)); 1434 browser->GetBubbleManager()->ShowBubble(std::move(bubble_delegate));
1435 bubble_delegate_ptr->set_bubble_controller(bubble_controller); 1435 bubble_delegate_ptr->set_bubble_controller(bubble_controller);
1436 1436
1437 return std::move(bluetooth_chooser_desktop); 1437 return std::move(bluetooth_chooser_desktop);
1438 } 1438 }
1439 1439
1440 bool Browser::RequestAppBanner(content::WebContents* web_contents) { 1440 bool Browser::RequestAppBanner(content::WebContents* web_contents) {
1441 banners::AppBannerManagerDesktop* manager = 1441 banners::AppBannerManagerDesktop* manager =
1442 banners::AppBannerManagerDesktop::FromWebContents(web_contents); 1442 banners::AppBannerManagerDesktop::FromWebContents(web_contents);
(...skipping 1287 matching lines...) Expand 10 before | Expand all | Expand 10 after
2730 if (contents && !allow_js_access) { 2730 if (contents && !allow_js_access) {
2731 contents->web_contents()->GetController().LoadURL( 2731 contents->web_contents()->GetController().LoadURL(
2732 target_url, 2732 target_url,
2733 content::Referrer(), 2733 content::Referrer(),
2734 ui::PAGE_TRANSITION_LINK, 2734 ui::PAGE_TRANSITION_LINK,
2735 std::string()); // No extra headers. 2735 std::string()); // No extra headers.
2736 } 2736 }
2737 2737
2738 return contents != NULL; 2738 return contents != NULL;
2739 } 2739 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | content/browser/bluetooth/bluetooth_dispatcher_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698